Comment 3 for bug 376128

Revision history for this message
David Decotigny (daviddecotigny) wrote :

Looking at the git, I noticed this changeset:
http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-jaunty.git;a=commit;h=4a90f09b20f4622dcbff1f0e1e6bae1704f8ad8c
This adds a few reference counting tweaks. Most notably, in ftdi_process_read, there reference acquires and release in the form of "goto out" (which release tty refs) almost everywhere EXCEPT one return still there... See line 2031 of jaunty's 2.6.28-13.44 official source for ftdi_sio.c, or this line:
http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-jaunty.git;a=blob;f=drivers/usb/serial/ftdi_sio.c;h=a0fbe1c7967e05183f01400b37f12ef64387c2c0;hb=HEAD#l2032

Looking at the ftdi_sio.c changes since commit fd05e720099e8eeddb378305d1a41c1445344b91, I didn't notice anything else which was not more or less cosmetic.

I have absolutely no idea 1/ whether a "goto out" would be even correct (I don't have a global vision of this driver), nor 2/ whether this would be the cause of our problems here. However, could anyone take a look at this ?