Comment 2 for bug 2067361

Hi Eero, thanks for the patch. Some comments:

* I targeted this bug to Jammy, since that's the only relevant series with py3.10
* changelog: note that we should close the bug with a syntax like LP: #2067361 instead of "Closes"

Now about the content - this patch is described as a "Minimal change of upstream fix". I get that this is a minimal backport, which is nice from a SRU perspective in terms of lines of code. That said, the logic in that commit and what's shown here are quite a bit different, much more than I expected to see from the "Minimal change" description, so plainly there are going to be differences in what is present in py3.11 and what would be supported here. I'm not sure I would call this an "obviously safe patch" per https://wiki.ubuntu.com/StableReleaseUpdates#Other_safe_cases

The upstream commit does have unit tests, I think it would be sensible to include relevant tests, and I'd suggest a discussion here on the merits of the current backported logic versus what the full upstream commit would offer.

My primary concern here is to not make some existing use cases worse while making this case better.

I'm going to unsubscribe Sponsors for the moment, please update this bug with your thoughts.