mstflint-dkms no longer exists in mantic

[dann frazier]

[Impact]
Users upgrading from jammy to mantic will not have an mstflint-dkms package. This will leave the mstflint-dkms package from jammy installed, which is incompatible with the 6.5 kernel.

The mstflint 4.21 package in mantic includes the kernel module source - it just doesn't build the mstflint-dkms package. The reason we ended up here was due to a bypass of the SRU process, described here:
https://bugs.launchpad.net/ubuntu/+source/mstflint/+bug/2051571/comments/1

mstflint 4.21's kernel source does not build with the 6.5 kernel in mantic. For that we need the 4.26 source. I looked at backporting src:mstflint 4.26 from noble in its entirety to resolve this issue, but aborted after finding a backwards compatibility issue in the mstflint deb (bug 2060026).

Instead, I'm looking to backport only the dkms changes from 4.26 into 4.21.

Now, this may seem like a lot to do for an obscure package in an interim release. But this is just a precursor to resolving bug 2051571 in jammy, which I expect to be a simple backport of the mantic SRU to jammy.

[Test Case]
- mstflint-dkms installs in mantic and builds against the mantic kernel.
- mstflint-dkms/mantic upgrades cleanly from jammy.
- mstflint-dkms/mantic upgrades cleanly to noble.

Regression test: compare the contents of the mstflint binary package before/after, makes sure the file list matches and maintainer scripts are equivalent.

[What Could Go Wrong]
Introducing the mstflint-dkms package should carry a low regression risk because the package does not already exist in mantic. However, the packaging changes could introduce regressions in the other binary package, mstflint, if they are buggy. The upstream version bump of the mstflint-dkms package needs to be handled carefully, or we'll risk breaking

[Timo Aaltonen (tjaalton)]

Hello dann, or anyone else affected,

Accepted mstflint into mantic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/mstflint/4.21.0+1-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-mantic to verification-done-mantic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-mantic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Timo Aaltonen (tjaalton)]

Hello dann, or anyone else affected,

Accepted mstflint into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/mstflint/4.21.0+1-1ubuntu0.1~22.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[dann frazier (dannf)]

# Verification

## Installs cleanly in mantic and builds against the mantic kernel:

ubuntu@akis:~$ sudo dpkg -i *.deb
Selecting previously unselected package mstflint-dkms.
(Reading database ... 87552 files and directories currently installed.)
Preparing to unpack mstflint-dkms_4.26.0+1-1ubuntu0.1_all.deb ...
Unpacking mstflint-dkms (4.26.0+1-1ubuntu0.1) ...
Preparing to unpack mstflint_4.21.0+1-1ubuntu0.1_amd64.deb ...
Unpacking mstflint (4.21.0+1-1ubuntu0.1) over (4.21.0+1-1) ...
dpkg: dependency problems prevent configuration of mstflint-dkms:
 mstflint-dkms depends on dkms (>= 2.1.0.0); however:
  Package dkms is not installed.
 mstflint-dkms depends on make; however:
  Package make is not installed.

dpkg: error processing package mstflint-dkms (--install):
 dependency problems - leaving unconfigured
Setting up mstflint (4.21.0+1-1ubuntu0.1) ...
Processing triggers for man-db (2.11.2-3) ...
Errors were encountered while processing:
 mstflint-dkms
ubuntu@akis:~$ sudo apt -f install
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Correcting dependencies... Done
The following additional packages will be installed:
  build-essential bzip2 cpp cpp-12 cpp-13 dkms dpkg-dev g++ g++-13 gcc gcc-12
  gcc-12-base gcc-13 libalgorithm-diff-perl libalgorithm-diff-xs-perl
  libalgorithm-merge-perl libcc1-0 libdpkg-perl libfile-fcntllock-perl libgcc-12-dev
  libstdc++-13-dev lto-disabled-list make
Suggested packages:
  bzip2-doc cpp-doc gcc-12-locales cpp-12-doc gcc-13-locales cpp-13-doc menu
  debian-keyring g++-multilib g++-13-multilib gcc-13-doc gcc-multilib autoconf
  automake libtool flex bison gdb gcc-doc gcc-12-multilib gcc-12-doc gcc-13-multilib
  bzr libstdc++-13-doc make-doc
The following NEW packages will be installed:
  build-essential bzip2 cpp cpp-12 cpp-13 dkms dpkg-dev g++ g++-13 gcc gcc-12
  gcc-12-base gcc-13 libalgorithm-diff-perl libalgorithm-diff-xs-perl
  libalgorithm-merge-perl libcc1-0 libdpkg-perl libfile-fcntllock-perl libgcc-12-dev
  libstdc++-13-dev lto-disabled-list make
0 upgraded, 23 newly installed, 0 to remove and 9 not upgraded.
1 not fully installed or removed.
Need to get 83.6 MB of archives.
After this operation, 277 MB of additional disk space will be used.
Do you want to continue? [Y/n]
Get:1 http://archive.ubuntu.com/ubuntu mantic/main amd64 cpp-13 amd64 13.2.0-4ubuntu3 [10.7 MB]
Get:2 http://archive.ubuntu.com/ubuntu mantic/main amd64 cpp amd64 4:13.2.0-1ubuntu1 [28.9 kB]
Get:3 http://archive.ubuntu.com/ubuntu mantic/main amd64 libcc1-0 amd64 13.2.0-4ubuntu3 [48.0 kB]
Get:4 http://archive.ubuntu.com/ubuntu mantic/main amd64 gcc-13 amd64 13.2.0-4ubuntu3 [21.5 MB]
Get:5 http://archive.ubuntu.com/ubuntu mantic/main amd64 gcc amd64 4:13.2.0-1ubuntu1 [5168 B]
Get:6 http://archive.ubuntu.com/ubuntu mantic/main amd64 gcc-12-base amd64 12.3.0-9ubuntu2 [43.6 kB]
Get:7 http://archive.ubuntu.com/ubuntu mantic/main amd64 cpp-12 amd64 12.3.0-9ubuntu2 [10.8 MB]
Get:8 http://archive.ubuntu.com/ubuntu mantic/main amd64 libgcc-12-dev amd64 12.3.0-9ubuntu2 [2574 kB]
Get:9 http://archive.ubuntu.com/ubuntu mantic/main amd64 gcc-12 amd64 12.3.0-9ubuntu2 [21.6 MB]
Get:10 http://ar...

[Andreas Hasenack (ahasenack)]

This couldn't have been possibly verified for mantic, because bin:mstflint-dkms is still in the mantic NEW queue[1].

1. https://launchpad.net/ubuntu/mantic/+queue?queue_state=0&queue_text=mstflint

[dann frazier (dannf)]

I downloaded the deb from LP (that's why the verification starts w/ a `dpkg -i`). Apologies that I did not call that out, I honestly thought I had.

[Robie Basak (racb)]

I pinged in #ubuntu-release for an AA review for the binary.

[Robie Basak (racb)]

The binary is accepted now. But if we're not going to use apt to try installing from proposed, I suppose I should wait for a britney run to ensure that there are no installability issues.

[Andreas Hasenack (ahasenack)]

I repeated these tests with the mstflint-dkms package from mantic-proposed (4.26.0+1-1ubuntu0.1):
- mstflint-dkms installs in mantic and builds against the mantic kernel.
- mstflint-dkms/mantic upgrades cleanly from jammy.
- mstflint-dkms/mantic upgrades cleanly to noble.

The module built and loaded in all cases, and the upgrades also happened without issues.

[Launchpad Janitor (janitor)]

This bug was fixed in the package mstflint - 4.21.0+1-1ubuntu0.1

---------------
mstflint (4.21.0+1-1ubuntu0.1) mantic; urgency=medium

  * Add mstflint-dkms package to avoid a regression from jammy.
    LP: #2061182. This backports the packaging changes from noble that
    introduce the mstflint-dkms binary, which depends on the following
    backport of the install-dkms target from upstream:
    - d/p/0001-debian-mstflint-mstflint-dkms-packages-generation.patch
  * A bug in the kernel module can lead to UBSAN errors in dmesg upon
    device closure. LP: #2061185. Backport changes to fix that:
    - d/p/0002-Fix-illegal-shift-in-mst_release.patch
    - d/p/0003-Fix-typo.patch (fix for previous patch)
  * Backport change to clarify the licensing terms for the mstflint_access
    kernel module. LP: #2061186.
    - d/p/0004-Add-missed-license.patch
  * The kernel modules source in mstflint 4.21 FTBFS w/ the 6.5 kernel.
    LP: #2043098. Backport changes to fix that:
    - d/p/0005-fix-kernel-module-build-on-kernel-6.4.patch
    - d/p/0006-kernel-module-fix-wrong-comparison-order.patch (fix for
      previous patch).
  * Since we have now backported every patch that touches the kernel module
    source between 4.21.0 and 4.26.0, use 4.26.0 as the upstream version for
    the mstflint-dkms deb. This requires a patch to let us override the
    version during the build:
    - d/p/kernel-module-config-version.patch

 -- dann frazier <email address hidden> Fri, 12 Apr 2024 14:26:39 -0600

[Andreas Hasenack (ahasenack)]

The verification of the Stable Release Update for mstflint has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.