mstflint-dkms FTBS with linux 6.5 on jammy

[Andrea Righi]

[Impact]

./include/linux/export.h:29:22: error: passing argument 1 of ‘class_create’ from incompatible pointer type [-Werror=incompatible-pointer-types]
   29 | #define THIS_MODULE (&__this_module)
      | ~^~~~~~~~~~~~~~~
      | |
      | struct module *

[Test case]

 $ sudo apt install mstflint-dkms

[Fix]

Backport from mantic the changes required to properly support the new Linux 6.5 ABI.

[Regression potential]

We may experience regressions in systems with NVIDIA that are loading the mstflint kernel module.

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: mstflint-dkms 4.21.0-7
ProcVersionSignature: User Name 6.5.0-9.9~22.04.2-generic 6.5.3
Uname: Linux 6.5.0-9-generic x86_64
ApportVersion: 2.20.11-0ubuntu82.5
Architecture: amd64
CasperMD5CheckResult: unknown
CloudArchitecture: x86_64
CloudID: nocloud
CloudName: unknown
CloudPlatform: nocloud
CloudSubPlatform: config-disk (/dev/vdb)
Date: Thu Nov 9 12:11:50 2023
PackageArchitecture: all
ProcEnviron:
 TERM=xterm-256color
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=C.UTF-8
 SHELL=/bin/bash
SourcePackage: mstflint
UpgradeStatus: No upgrade log present (probably fresh install)

[Andrea Righi (arighi)]

Properly cleaned up debdiff in attach.

[Andrea Righi (arighi)]

v2 of the debdiff (more cleanup), sorry for the noise.

[Andrea Righi (arighi)]

- debdiff tested with the new 6.5 kernel:

13:32 ubuntu@jammy$ sudo dpkg -i mstflint-dkms_4.21.0-7ubuntu1_all.deb
Selecting previously unselected package mstflint-dkms.
(Reading database ... 160618 files and directories currently installed.)
Preparing to unpack mstflint-dkms_4.21.0-7ubuntu1_all.deb ...
Unpacking mstflint-dkms (4.21.0-7ubuntu1) ...
Setting up mstflint-dkms (4.21.0-7ubuntu1) ...
Loading new mstflint-4.21.0-7ubuntu1 DKMS files...
Building for 6.5.0-9-generic
Building initial module for 6.5.0-9-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

mstflint_access.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/6.5.0-9-generic/updates/dkms/

- and same debdiff tested with the GA kernel:

$ sudo dpkg -i mstflint-dkms_4.21.0-7ubuntu1_all.deb
(Reading database ... 143086 files and directories currently installed.)
Preparing to unpack mstflint-dkms_4.21.0-7ubuntu1_all.deb ...
Unpacking mstflint-dkms (4.21.0-7ubuntu1) over (4.21.0-7ubuntu1) ...
Setting up mstflint-dkms (4.21.0-7ubuntu1) ...
Loading new mstflint-4.21.0-7ubuntu1 DKMS files...
Building for 5.15.0-90-generic
Building initial module for 5.15.0-90-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

mstflint_access.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-90-generic/updates/dkms/

depmod...

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "mstflint-dkms-support-linux-6.5-jammy.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Julian Andres Klode (juliank)]

Sponsored with minor edit to the version number to ubuntu0.1, please make sure to use the correct version number for future SRUs.

Please also add instructions on how to install 6.5 kernel to the test case before this can be SRU approved.

[Timo Aaltonen (tjaalton)]

Hello Andrea, or anyone else affected,

Accepted mstflint into mantic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/mstflint/4.21.0+1-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-mantic to verification-done-mantic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-mantic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Timo Aaltonen (tjaalton)]

Hello Andrea, or anyone else affected,

Accepted mstflint into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/mstflint/4.21.0+1-1ubuntu0.1~22.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[dann frazier (dannf)]

# mantic verification

Setting up mstflint-dkms (4.26.0+1-1ubuntu0.1) ...
Loading new mstflint-4.26.0+1-1ubuntu0.1 DKMS files...
Building for 6.5.0-28-generic
Building initial module for 6.5.0-28-generic
Secure Boot not enabled on this system.
Done.

mstflint_access.ko.zst:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/6.5.0-28-generic/updates/dkms/
depmod...
Setting up g++ (4:13.2.0-1ubuntu1) ...
update-alternatives: using /usr/bin/g++ to provide /usr/bin/c++ (c++) in auto mode
Setting up build-essential (12.10ubuntu1) ...
Processing triggers for man-db (2.11.2-3) ...
Processing triggers for libc-bin (2.38-1ubuntu6.2) ...
needrestart is being skipped since dpkg has failed
ubuntu@akis:~$ sudo modprobe mstflint_access
ubuntu@akis:~$ lsmod | grep mstflint
mstflint_access 28672 0

[dann frazier (dannf)]

# jammy verification
ubuntu@hinyari:~$ sudo apt install mstflint-dkms
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following package was automatically installed and is no longer required:
  libnuma1
Use 'sudo apt autoremove' to remove it.
The following packages will be upgraded:
  mstflint-dkms
1 upgraded, 0 newly installed, 0 to remove and 41 not upgraded.
1 not fully installed or removed.
Need to get 19.0 kB of archives.
After this operation, 4096 B of additional disk space will be used.
Get:1 http://ports.ubuntu.com/ubuntu-ports jammy-proposed/universe arm64 mstflint-dkms all 4.26.0+1-1ubuntu0.1~22.04.1 [19.0 kB]
Fetched 19.0 kB in 0s (74.1 kB/s)
(Reading database ... 134181 files and directories currently installed.)
Preparing to unpack .../mstflint-dkms_4.26.0+1-1ubuntu0.1~22.04.1_all.deb ...
Deleting module mstflint-4.21.0-7 completely from the DKMS tree.
Unpacking mstflint-dkms (4.26.0+1-1ubuntu0.1~22.04.1) over (4.21.0-7) ...
Setting up mstflint-dkms (4.26.0+1-1ubuntu0.1~22.04.1) ...
Loading new mstflint-4.26.0+1-1ubuntu0.1~22.04.1 DKMS files...
Building for 6.5.0-28-generic-64k 6.5.0-1015-nvidia-64k
Building initial module for 6.5.0-28-generic-64k
Can't load /var/lib/shim-signed/mok/.rnd into RNG
2000AC2B5DE40000:error:12000079:random number generator:RAND_load_file:Cannot open file:
../crypto/rand/randfile.c:106:Filename=/var/lib/shim-signed/mok/.rnd
...+..+.+..+.+....................++++++++++++++++++++++++++++++++++++++++++++++++++++++
+++++++++++*.......+.....+...+..........+..+.......+.....+.......+...+.....+.+++++++++++
++++++++++++++++++++++++++++++++++++++++++++++++++++++*....+...+..........+.....+.......
+.....+...+....+........+.+.........+.....+.++++++++++++++++++++++++++++++++++++++++++++
+++++++++++++++++++++
.+..+...+.......+...+......+...........+.+..+...++++++++++++++++++++++++++++++++++++++++
+++++++++++++++++++++++++*..+..+.........+...+.+......+......+.........+...+++++++++++++
++++++++++++++++++++++++++++++++++++++++++++++++++++*..+.......+...........+....+.....+.
....................+...............+.+......+.....+...+......+.+..+.......+...+..+...+.
..+...+................+.....+.+...+.....+.+........+.+..+...+......+..........+...+..+.
...............+..+.+................................+...+....+...+..+.............+....
....+......+.+.........+.........+.................+....+...........+..................+
.+........+.............+.....+.......+..+.+...............+.....+..........+...+.......
....+..........+...+........+...+..........+......+.....+.+...+......+...+..+...+.......
.....+....+.....+............+.......+...........+.+...+.....+......+....+..+..........+
.....+...+.+..+...+....+...+........+.......+...+...........+...+...+....+..............
+..........+..............+.......+.....+.+............+.....+......+.+...+.............
....+....+..+....+...+..+....+.........+...+...+......+.....+.+..+............+.+.......
..+........+......+.+...+..+.........+......+......+............+.......+......+...+..+.
...+...+..+..........+.....+.+.........+.....+.+..+.........................+......+..+.
...........+...+....+...+......+.....+...........

[Andreas Hasenack (ahasenack)]

Whenever we have an Ubuntu release that can have two mainline kernels, and the issue is a module FTBFS, we need to test the updated dkms build in both the GA kernel and the HWE one. Since this was not requested in the approved test plan for this SRU, I did it manually for jammy.

I thus verified that:
a) old dkms builds and loads with jammy's GA kernel
b) old dkms fails to build with jammy's HWE kernel
c) new dkms builds and loads with jammy's GA kernel
d) new dkms builds and loads with jammy's HWE kernel (the original test plan).

I also note that the test plan was not updated with the recommendation from comment #7, i.e., instructions on how to install the HWE kernel (and headers) in jammy. I myself always struggle with finding the correct kernel packages among the hundreds variants we have in the archive. For posterity, these were the packages to get the HWE kernel and headers in a jammy vm:

- linux-headers-virtual-hwe-22.04
- linux-image-virtual-hwe-22.04