[SRU] Fix compilation errors on 5.19
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
licheerv-rtl8723ds-dkms (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Jammy |
New
|
Undecided
|
Unassigned | ||
Kinetic |
Fix Released
|
Undecided
|
Unassigned | ||
Lunar |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[ Impact ]
This dkms package builds the driver on the host and it fails to compile on 5.19 kernels with the following errors:
/home/itrue/
6821 | .stop_ap = cfg80211_
| ^~~~~~~
/home/itrue/
/home/itrue/
/home/itrue/
7052 | if (wdev->current_bss) {
| ^~
We need to backport this fix as the 5.19 linux kernel for this board is in proposed and will finally migrate after the release.
[ Test Plan ]
$ sudo apt install licheerv-
Selecting previously unselected package licheerv-
(Reading database ... 112897 files and directories currently installed.)
Preparing to unpack licheerv-
Unpacking licheerv-
Setting up licheerv-
Loading new licheerv-
Building for 5.19.0-
Building initial module for 5.19.0-
Done.
8723ds.ko:
Running module version sanity check.
- Original module
- No original module exists within this kernel
- Installation
- Installing to /lib/modules/
depmod.
The build of the module will take quite some time (more than 1hour..).
$ sudo ip link set dev wlan0 up
And finally use the following netplan configuration to connect to your AP (to store at /etc/netplan/
network:
version: 2
renderer: networkd
wifis:
wlan0:
dhcp4: yes
dhcp6: yes
access-points:
"YOUR_SSID":
password: "YOUR_PASSWORD"
$ sudo netplan apply
Finally, we should be connected to the AP:
$ ip a
1: lo: <LOOPBACK,
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
inet 127.0.0.1/8 scope host lo
valid_lft forever preferred_lft forever
inet6 ::1/128 scope host
valid_lft forever preferred_lft forever
2: usb0: <NO-CARRIER,
link/ether ae:12:05:64:8e:2c brd ff:ff:ff:ff:ff:ff
3: wlan0: <BROADCAST,
link/ether 34:20:03:2a:0d:0c brd ff:ff:ff:ff:ff:ff
inet 192.168.1.28/24 metric 600 brd 192.168.1.255 scope global dynamic wlan0
valid_lft 86393sec preferred_lft 86393sec
inet6 fe80::3620:
valid_lft forever preferred_lft forever
[ Where problems could occur ]
One part of the fix is straightforward: it is the addition of a new parameter in a callback.
The other part is based on the upstream commit that removed "current_bss" field, there may be an oversight/
tags: | added: foundation-todo |
description: | updated |
summary: |
- FIx compilation errors on 5.19 + [SRU] FIx compilation errors on 5.19 |
summary: |
- [SRU] FIx compilation errors on 5.19 + [SRU] Fix compilation errors on 5.19 |
tags: |
added: foundations-todo removed: foundation-todo |
Status changed to 'Confirmed' because the bug affects multiple users.