requires bc and is not -Wdate-time clean

[Dimitri John Ledkov]

[ Impact ]

 * Package fails to install under certain conditions

[ Test Plan ]

 * apt remove --purge bc

 * apt install linux-allwinner

 * apt install licheerv-rtl8723ds-dkms

[ Where problems could occur ]

 * The solution to the above issue drops usage of __DATE__ and __TIME__ macros, such that debug output from this module will no longer print a line as to when the module is built. Such usage is prohibited in the kernel, and shouldn't be used by dkms modules either.

[ Other Info ]

 * Regression present in the original kinetic packaging, which neither depends on bc, nor has any other ways to mitigate this.

original description

requires bc and is not -Wdate-time clean

currently this dkms module is not -Wdate-time clean and requires bc to override that, when building with compilers from this decade.

Fix this by make the module -Wdate-time clean.

[Launchpad Janitor (janitor)]

This bug was fixed in the package licheerv-rtl8723ds-dkms - 1.0-0ubuntu3

---------------
licheerv-rtl8723ds-dkms (1.0-0ubuntu3) lunar; urgency=medium

  * Fix -Wdate-time and drop -Wno-date-time override. LP: #1996753

 -- Dimitri John Ledkov <email address hidden> Wed, 16 Nov 2022 13:27:29 +0000

[Brian Murray (brian-murray)]

Hello Dimitri, or anyone else affected,

Accepted licheerv-rtl8723ds-dkms into kinetic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/licheerv-rtl8723ds-dkms/1.0-0ubuntu1.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-kinetic to verification-done-kinetic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-kinetic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Dimitri John Ledkov (xnox)]

# apt remove --purge bc
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Package 'bc' is not installed, so not removed
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.

# apt install licheerv-rtl8723ds-dkms
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done

...
Preparing to unpack .../licheerv-rtl8723ds-dkms_1.0-0ubuntu1.2_riscv64.deb ...
Unpacking licheerv-rtl8723ds-dkms (1.0-0ubuntu1.2) ...
Setting up dh-dkms (3.0.6-2ubuntu2) ...
Setting up dctrl-tools (2.24-3build2) ...
Setting up dkms (3.0.6-2ubuntu2) ...
Setting up licheerv-rtl8723ds-dkms (1.0-0ubuntu1.2) ...
Loading new licheerv-rtl8723ds-1.0 DKMS files...
It is likely that 5.15.0-52-generic belongs to a chroot's host
Building for 5.19.0-1003-allwinner
Building initial module for 5.19.0-1003-allwinner
Done.

8723ds.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.19.0-1003-allwinner/updates/dkms/
depmod....
Processing triggers for libc-bin (2.36-0ubuntu4) ...

# dkms status
licheerv-rtl8723ds/1.0, 5.19.0-1003-allwinner, riscv64: installed

All is good.

[Launchpad Janitor (janitor)]

This bug was fixed in the package licheerv-rtl8723ds-dkms - 1.0-0ubuntu1.2

---------------
licheerv-rtl8723ds-dkms (1.0-0ubuntu1.2) kinetic; urgency=medium

  * Fix -Wdate-time and drop -Wno-date-time override. LP: #1996753

licheerv-rtl8723ds-dkms (1.0-0ubuntu1.1) kinetic; urgency=medium

  * Fix compilation errors on 5.19 kernels (LP: #1993274)
    Change maintainer to Ubuntu Developers.

 -- Dimitri John Ledkov <email address hidden> Wed, 16 Nov 2022 13:27:29 +0000

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for licheerv-rtl8723ds-dkms has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.