Comment 4 for bug 1973229

Revision history for this message
Jeremy BĂ­cha (jbicha) wrote :

Robie, thank you for taking the time to review this proposed stable release update. Let me try to provide more justification for this proposed update.

Yes, I am treating this as a microrelease update which according to my understanding will not require specific bug reports and verification for each patch but just an overall test case for the update.

The GNOME Remote Desktop maintainer has strongly and repeatedly urged distros to take the freerdp2 2.7.0 release. GNOME 42 is the first GNOME release to offer RDP Sharing and there are several bugfixes and crashes fixed in the new freerdp2 version. Since GNOME Remote Desktop sharing is the primary usecase for freerdp2 in Ubuntu 22.04 LTS, I think the opinion of the upstream maintainers carries some weight here. The secondary usecase is the remote desktop client Remmina so that's why the manual test plan tests that feature too.

To try to minimize the change needed for this SRU, we cherry-picked 23 non-changelog commits from 2.7.0 to Ubuntu 22.04 LTS already. This proposed SRU adds the 8 remaining commits. I believe that for users seeking support upstream, it will be easier if they can report that they are using 2.7.0 rather than effectively a git snapshot especially since the git snapshot isn't obvious from the Ubuntu version number (you'd have to read debian/changelog to know this).

I understand that the packaging update is really noisy because of so many patches dropped. Therefore, I am attaching a diff of the code change now for the patched source (excluding the debian/ directory). Or you can browse the git commit log linked in the bug description for commits after April 11.

The 2.7.0 update is an update from freerdp2's stable branch. The changes are all limited backports from the main trunk development branch.

The final change is backporting another patch set (from the stable branch after the 2.7.0 release). That change is difficult to verify with our usual SRU procedures. It fixes a crash that we don't know how to reliably reproduce. The easiest verification that the patch works is to monitor errors.ubuntu.com to make sure that the crash reports stop. But you can't really do that until the updated version is pushed to jammy-updates, right?