Today, I tackled the Mantic debdiff (made only a few changes; below).
It's now currently building in a PPA for all supported architectures,
(ppa:mfo/lp2038249) and if all goes well I will upload it to Mantic.
Thanks!
Mauricio
---
All 24 commits are included in Noble (12 in 8.0.4 and 12 in 8.0.3).
changelog OK
DEP3 tags OK
I reviewed each commit, with the exception of the big code additions
(patches 8,16: for maple tree and module memory layout): all look OK.
I fixed up patch 24, which is originally 2 trivial and short changes,
but had like ~3800 lines of indentation/formatting changes included
(certainly this wasn't intented, and mistakes happen; so I fixed it).
$ git show 55a43bcefa20161c7e56ed0e309e90e941f47efc | wc -l
57
We can all learn from this -- I will check .patch files with diffstat!
I also just augmented backport notes (thanks for those) to indicate
which functions/hunks had context lines modified/adjusted/refreshed,
since the patch is big (patch 15), and clarify variables (not) used.
-+[chengen - modify x86_64.c context]
++[chengen - modify context in x86_64.c: x86_64_ORC_init() and x86_64_get_framesize()]
-+[chengen - initialize init_tss to zero in xen_hyper.c]
++[chengen - initialize only init_tss to zero in xen_hyper.c (there is no stack_base yet)]
Very importantly, the detailed test plan will be key to validate the
changes are working correctly, considering their number and size.
Thanks again for it!
Today, I tackled the Mantic debdiff (made only a few changes; below).
It's now currently building in a PPA for all supported architectures,
(ppa:mfo/lp2038249) and if all goes well I will upload it to Mantic.
Thanks!
Mauricio
---
All 24 commits are included in Noble (12 in 8.0.4 and 12 in 8.0.3).
changelog OK
DEP3 tags OK
I reviewed each commit, with the exception of the big code additions
(patches 8,16: for maple tree and module memory layout): all look OK.
I fixed up patch 24, which is originally 2 trivial and short changes, formatting changes included
but had like ~3800 lines of indentation/
(certainly this wasn't intented, and mistakes happen; so I fixed it).
$ git show 55a43bcefa20161 c7e56ed0e309e90 e941f47efc | wc -l
57
$ wc -l debian/ patches/ lp2038249- 0024-Fix- compilation- error-and- warning- with-gcc- 4.8.5.patch patches/ lp2038249- 0024-Fix- compilation- error-and- warning- with-gcc- 4.8.5.patch
3865 debian/
We can all learn from this -- I will check .patch files with diffstat!
I also just augmented backport notes (thanks for those) to indicate adjusted/ refreshed,
which functions/hunks had context lines modified/
since the patch is big (patch 15), and clarify variables (not) used.
-+[chengen - modify x86_64.c context] get_framesize( )]
++[chengen - modify context in x86_64.c: x86_64_ORC_init() and x86_64_
-+[chengen - initialize init_tss to zero in xen_hyper.c]
++[chengen - initialize only init_tss to zero in xen_hyper.c (there is no stack_base yet)]
Very importantly, the detailed test plan will be key to validate the
changes are working correctly, considering their number and size.
Thanks again for it!