Comment 18 for bug 1994521

Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

Hi Seyeong,

Thanks for the patches!

In the future, could you please add DEP-3 headers [1] to them?
(usually just 'Bug-Ubuntu:'/'Origin:' are needed on git patches)

Also, it's a good practice to name the patch files with the bug
prefix (this is style, not requirement, but it helps when there
is multiple bugs per upload, and with maintenance over time).

I have handled these in this upload, as the changes are minor.
Thanks again!

[1] https://dep-team.pages.debian.net/deps/dep3/

$ head -n2 debian/patches/lp1994521-*

==> debian/patches/lp1994521-0001-HPE-3PAR-Fix-umanaged-volumes-snapshots-missing.patch <==
Bug-Ubuntu: http://bugs.launchpad.net/bugs/1994521
Origin: https://review.opendev.org/c/openstack/cinder/+/907257

==> debian/patches/lp1994521-0002-3PAR-Error-out-if-vol-cannot-be-converted-to-base.patch <==
Bug-Ubuntu: http://bugs.launchpad.net/bugs/1994521
Origin: https://review.opendev.org/c/openstack/cinder/+/907258