Comment 28 for bug 1998311

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

I noticed that the jammy upload has a stray hunk in the patch[1], at the end:

--- /dev/null
+++ b/mod_proxy_hcheck_jammy_fix_to_detect_support.patch
@@ -0,0 +1 @@
+

That will create an empty mod_proxy_hcheck_jammy_fix_to_detect_support.patch file at the root of the source code[2]:

$ dquilt push -a
...
Applying patch mod_proxy_hcheck_jammy_fix_to_detect_support.patch
patching file modules/proxy/mod_proxy_hcheck.c
patching file mod_proxy_hcheck_jammy_fix_to_detect_support.patch

Now at patch mod_proxy_hcheck_jammy_fix_to_detect_support.patch

$ ls -la
...
-rw-rw-r-- 1 andreas andreas 53749 abr 27 10:08 Makefile.win
-rw-rw-r-- 1 andreas andreas 1 abr 27 10:40 mod_proxy_hcheck_jammy_fix_to_detect_support.patch
drwxrwxr-x 29 andreas andreas 4096 abr 27 10:08 modules
...

Another small issue is that the date in the DEP3 header of the jammy patch is incorrect:

$ grep Last-Update debian/patches/mod_proxy_hcheck_jammy_fix_to_detect_support.patch
Last-Update: 2022-03-01

None of these affect the build or the final result in the binary package, but it's something that should have been flagged and fixed prior to the upload.

Since it does not affect the build, and the package is in proposed already, I'll release it, but please double check next time.

1. https://git.launchpad.net/ubuntu/+source/apache2/tree/debian/patches/mod_proxy_hcheck_jammy_fix_to_detect_support.patch?h=applied/ubuntu/jammy-devel
2. https://git.launchpad.net/ubuntu/+source/apache2/tree/mod_proxy_hcheck_jammy_fix_to_detect_support.patch?h=applied/ubuntu/jammy-devel