Comment 21 for bug 2059756

Revision history for this message
Gabriel Nagy (gabuscus) wrote :

Hi Steve,

Thanks for the review. Here are my responses for the not-accepted packaging bits:

- debian/prerm: thank you for catching this, I don't know how it slipped through, I guess it was all the false encouragement given by packages in the wild that employ the same (broken) prerm workflow. I've opened a PR to revert this upstream https://github.com/ubuntu/adsys/pull/1026 -- I don't think it adds much value to have this working (and it was not explicitly documented in the changelog either, so I'm happy with removing the broken code, as it never worked)
- krb5/winbind as an alternative to sssd: this was explicitly requested by paying customers with specific requirements related to cross-domain forest setups which could not be satisfied by sssd directly -- it's documented (albeit in a terse manner, only mentioning winbind) in the 0.10.0 changelog
- addition of Depends: apparmor: opted for this because the apparmor policy manager subprocesses "apparmor_parser" (ref: https://github.com/ubuntu/adsys/blob/b20890f78bd55d5b5c90d77af61d17eb31f40b77/internal/policies/apparmor/apparmor.go#L82) -- happy to drop it if you think it's the best practice
- additional of dependency on nfs-common: opted for a "Depends" here because adsys could apply a nfs mount policy which would fail hard if nfs-common were not installed -- I would've gone for "Recommends" in case of a soft warning

Thanks,
Gabriel