[regression, intrepid] redraw problems, patches from fedora

[Robert Jordens]

Applications which use libgnomecanvas, such as xournal, do not update the screen properly when the user draws lines. Some lines don't appear, others are shown after the cursor moves off the canvas, others are partially displayed and are later completed after releasing the mouse button. This was patched, but did not solve the problem. The updated patch is located https://bugzilla.novell.com/show_bug.cgi?id=430785 and the debdiff is at http://launchpadlibrarian.net/19312323/libgnomecanvas_2.20.1.1-1ubuntu3.debdiff

Testcase:
1) Launch xournal
2) Maximize the window (it seems to help exacerbate the effect)
3) Try to draw by clicking, then holding the first mouse button and moving around
4) Wait a bit, then release. Notice the delayed update.

[James Westby (james-w)]

Hi,

I'm subscribing the sponsors team, in this case ubuntu-main-sponsors, which
you should do if you have a debdiff you would like to see uploaded.

Thanks,

James

[Hpj-u (hpj-u)]

Created attachment 242388
teg package

Federico,

as I've already described in:
[opensuse-gnome] next issue with GNOME:STABLE: canvases aren't redrawed correctly

it still holds true for 11.0:
I suffer from canvases and its items, that aren't redrawed correctly in teg
(a risk clone, I happily provide a src.rpm for anyone interested). This
game uses a canvas with some items, and those aren't updated correctly.
Forcing a redraw by switching screens, or moving a window over them fixes
this, but that's an unplayable state.

The fact is, it doesn't happen with upstream libgnomecanvas nor does it happen if I prevent libgnomecanvas-no-tearing.diff from applying to the libgnomecanvas-2.20.1.1-42.1, thus there is either a problem in your patch, or a problem in teg.

May I ask you kindly for a fix (either way). I've attached the source rpm of the problematic package. The applied patches just change/add some shortcuts and a minor different default play mode..

BTW: I already tried to fix teg in some way, by sprinkle gnome_canvas_update_now() calls to various (random) places, but all I harvested was worser behavior. After messing in teg for a few hours, I tried above approach, and succeeded immediately.

[Federico-9 (federico-9)]

Huh, I had already fixed this for openSUSE 10.3 in bug #336941. Somehow the fixed patch didn't make it into openSUSE 11.0. Thanks for catching this; I'll submit an update.

[Federico-9 (federico-9)]

Created attachment 242687
Updated libgnomecanvas-no-tearing.diff

This is the fix that went into openSUSE 10.3; it fixes the repainting problem.

[Federico-9 (federico-9)]

Anja, could we please have a swampid to release this for openSUSE 11.0? This is a fix that didn't get carried over from 10.3; the updated patch has the fix.

[Hpj-u (hpj-u)]

Federico, I can confirm, that the provided patch fixes this issue.

Could you do me a favor, and raise the release version above 42.3. That way, you're getting the final release test for free ;-)

Federico, thanks for the breathtakingly quick reply and fix,
Pete

[Daniel Holbach (dholbach)]

libgnomecanvas-2.19.2-avoid-tearing.patch was accepted upstream: http://svn.gnome.org/viewvc/libgnomecanvas/trunk/libgnomecanvas/gnome-canvas.c?r1=1257&r2=1263

[Daniel Holbach (dholbach)]

zoom-redraw-fix.patch too: http://svn.gnome.org/viewvc/libgnomecanvas/trunk/libgnomecanvas/gnome-canvas.c?r1=1263&r2=1286

[Federico-9 (federico-9)]

Submitted for openSUSE 11.0. The update should appear soon.

Thanks, Anja, and thanks to Hans-Peter for catching this :)

[Federico-9 (federico-9)]

*** Bug 425710 has been marked as a duplicate of this bug. ***

[Sebastien Bacher (seb128)]

thank you for your bug report, hardy has exactly the same libgnomecanvas so if the issue is new in intrepid that's not likely due to it

[Sebastien Bacher (seb128)]

could you also use a proper patch in the debian directory rather than patching directly the source?

[Launchpad Janitor (janitor)]

This bug was fixed in the package libgnomecanvas - 2.20.1.1-1ubuntu2

---------------
libgnomecanvas (2.20.1.1-1ubuntu2) intrepid; urgency=low

  * debian/patches/90_upstream_correctly_update.patch:
    - upstream change to fix canvas update issues, thank to Robert Jordens
      who opened the bug and suggested the change (lp: #272316)

 -- Sebastien Bacher <email address hidden> Wed, 08 Oct 2008 23:32:33 +0200

[Ken Arnold (kenneth-arnold)]

I think this just /broke/ xournal updating. I couldn't try out the hardy version without downgrading all of gtk, so I can't confirm unless somebody posts the previous intrepid package. But I'm definitely getting new issues that sound much like what the reporter described after upgrading this morning.

[Ken Arnold (kenneth-arnold)]

Confirmed that this patch BROKE xournal. The canvas basically didn't update unless a redraw was forced (window switching, scrolling, etc.). Occasionally it would partially draw some other part of some line, but never what I had just drawn. I rebuilt libgnomecanvas /disabling/ the patch and xournal now redraws just fine again.

[Ast-x (ast-x)]

released

[Akos Ladanyi (akos-ladanyi)]

This was reported also by me in Bug 408012. That one can be closed now too.

[Federico-9 (federico-9)]

*** Bug 408012 has been marked as a duplicate of this bug. ***

[zoomy942 (zoomy942)]

I am confirming and subscribing to this bug also. I have the same problem.

[zoomy942 (zoomy942)]

Is there a fix?

[Ken Arnold (kenneth-arnold)]

I'm attaching the rebuild I did; I just disabled the patch described here and rebuilt. But do post if it works for you; let's see if we can get this reopened.

The attachment comes with no warranty! :)

[zoomy942 (zoomy942)]

I DL'ed that and it was for the i386 type. I'm AMD64. We're close my friend!

[Joe Smith (yasumoto7)]

According to https://bugs.edge.launchpad.net/ubuntu/+source/libgnomecanvas/+bug/284530, a fixed patch is located at https://bugzilla.novell.com/show_bug.cgi?id=430785. I'm attaching a new debdiff which (hopefully) fixes the problem.

[Kevin Goldstein (parktownprawn)]

thanks - i can confirm the debdiff fixed the problem for me

[Bogdan Radu (bog-radu)]

Thanks!
I can also confirm it worked for me.

[zoomy942 (zoomy942)]

This may sound silly - but what do I do with that debdiff?

[Andcor (corneliussen)]

I can also confirm that this debdiff fixes the issue for me.

I too was a bit confused about what to do about such a debdiff, but then a quick search at google got me this: https://wiki.ubuntu.com/UbuntuPackagingGuide/BuildFromDebdiff which told me anything I needed to know.

Thank you very much for the patch.

[zoomy942 (zoomy942)]

So, i feel silly becasue I get an error but I dont know why.

[Andcor (corneliussen)]

you should replace any instances of PACKAGE with libgnomecanvas.
Furthermore, when you come to the point where you shall perform the apt-get
source command you shall do it like this

apt-get source libgnomecanvas libgnomecanvas2-0

And you should do the apt-get build-dep like this

apt-get build-dep libgnomecanvas2-0

[OmniUni (omniuni)]

Installing the built *.deb above worked perfectly for me. I accidentally marked this bug under Xournal, my apologies for that, but things work fine now, I hope this fix makes it in soon.

[Bruno Ranieri (mail-bruno-ranieri)]

libgnomecanvas_2.20.1.1-1ubuntu3.debdiff solves the problem for me with Ubuntu 8.10 on amd64.

[zoomy942 (zoomy942)]

okay - i got stuck again...

this step

cd PACKAGE-* && patch -p1 < ../DEBDIFF

fails...

bash: cd: PACKAGE-*: No such file or directory
zimmerman@ubuntu-tablet:~/Desktop/PACKAGE$ cd libgnomecanvas-* && patch -p1 < ../DEBDIFF
bash: ../DEBDIFF: No such file or directory
zimmerman@ubuntu-tablet:~/Desktop/PACKAGE/libgnomecanvas-2.20.1.1$

cant someone just attach the deb they made or email it to me?

[Joe Smith (yasumoto7)]

Every time the wiki mentions PACKAGE, you should replace it with
"libgnomecanvas2-0" and in this case the DEBDIFF is
libgnomecanvas_2.20.1.1-1ubuntu3.debdiff (unless it's named something else).

On Sat, Nov 1, 2008 at 8:48 PM, zoomy942 <email address hidden> wrote:

> okay - i got stuck again...
>
> this step
>
> cd PACKAGE-* && patch -p1 < ../DEBDIFF
>
> fails...
>
> bash: cd: PACKAGE-*: No such file or directory
> zimmerman@ubuntu-tablet:~/Desktop/PACKAGE$ cd libgnomecanvas-* && patch
> -p1 < ../DEBDIFF
> bash: ../DEBDIFF: No such file or directory
> zimmerman@ubuntu-tablet:~/Desktop/PACKAGE/libgnomecanvas-2.20.1.1$
>
>
> cant someone just attach the deb they made or email it to me?
>
> --
> [regression, intrepid] redraw problems, patches from fedora
> https://bugs.launchpad.net/bugs/272316
> You received this bug notification because you are a direct subscriber
> of the bug.
>

[zoomy942 (zoomy942)]

Why am I not getting this?

[Francois Deppierraz (francois-ctrlaltdel)]

I can confirm that applying libgnomecanvas_2.20.1.1-1ubuntu3.debdiff does indeed fix redraw problems with xournal.

[Andcor (corneliussen)]

I do not know why you can't understand it, but it seems that some of the
steps has been completed as they should. The thing you should do now:

   1. Open a new terminal
   2. cd ~/Desktop/PACKAGE
   3. sudo apt-get build-dep libgnomecanvas2-0
   4. cd libgnomecanvas_2.20.1.1
   5. patch -p1 < ../libgnomecanvas_2.20.1.1-1ubuntu3.debdiff
   6. debuild -uc -us
   7. sudo dpkg -i ../libgnomecanvas*.deb

It isn't that hard

Francois Deppierraz wrote:
> I can confirm that applying libgnomecanvas_2.20.1.1-1ubuntu3.debdiff
> does indeed fix redraw problems with xournal.
>
>

[Sebastien Bacher (seb128)]

thank you for your work there, intrepid is stable now so the change needs to go to intrepid-proposed and not intrepid, the control change is also not required in the debdiff, could you update the debdiff to reflect that and also add a testcase to the bug description?

[zoomy942 (zoomy942)]

What is going on?

gah!

zimmerman@zimmerman-desktop:~/Desktop/PACKAGE$ cd libgnomecanvas_2.20.1.1
bash: cd: libgnomecanvas_2.20.1.1: No such file or directory
zimmerman@zimmerman-desktop:~/Desktop/PACKAGE$

[khul (klas-hultqvist)]

I also confirm that libgnomecanvas_2.20.1.1-1ubuntu3.debdiff did the trick for xournal for intrepid on an hp tc4400 tablet pc.

[zoomy942 (zoomy942)]

Now it seems silly that I can't get it to work.

Are .debs not allowed to be attached? That would be a million times easier for a guy like me who has never compiled anything before.

[zoomy942 (zoomy942)]

FYI - I downloaded the rpm for fedora, and tried converting it to a deb, but i have the AMD64 install and the rpm is for i386.

[Andcor (corneliussen)]

I don't have any amd64 setups so I can't make debs for you. but give me
an terminal with sudo access on your computer and I will do it for you.

Andreas

[Hugh Eaves (hugh-hugheaves)]

Here's the amd64 deb. This fixed the problem for me.

[Joe Smith (yasumoto7)]

Alright, here's the actual upstream bug in libgnomecanvas.

[zoomy942 (zoomy942)]

@ Hugh - Thanks so much! That worked great on my 3 Tablet PC's I have!

[nkri (nkri)]

I can confirm that Ken Arnold's rebuilt package without the patch works great on my Toshiba Portege M400. Thanks!
-nkri

[Hpj-u (hpj-u)]

Hi Federico,

I've no idea, why the symptoms of this bug reappeared in 11.1, especially since your no-tearing.diff is applied, but unfortunately, they are.

Let me know, if you're able to reproduce this.

[Pietro Battiston (toobaz)]

Actually, the package was tested by many and reported to work; it is true that without the patch the bug is not here, however notice the patch is not intended to solve this bug, but another one (having to do with tearing), so this is not strange.

Are you sure you didn't someway take the old version of the patch (from 2.20.1.1-1ubuntu2 or from the web)?

[Andcor (corneliussen)]

I see the exact same problem as Bob does. I first thougt it was because
I had set the virtual property in my xorg.conf, but If Bob has found a
solution to the problem I am all ears.
How did you remove the 90_upstream_correctly_update.patch Bob? I have
tried to make an apt-get source xournal in order to get the ubuntu
source code, but I didn't get the patches and the problem is still
present if just compiling the source code.

[Bob McElrath (bob+ubuntu)]

Absolutely positive about my versioning. I did an 'apt-get source libgnomecanvas' which gets libgnomecanvas_2.20.1.1-1ubuntu3, and built it by hand, with and without that patch which is a part of this package. The ubuntu-compiled package that was installed by default in intrepid definitely has the above problem. Took me nearly a week to track down the source...

The -1ubuntu2 package attached to this bug has the problem I see too.

Andcor: 'apt-get source libgnomecanvas' will create the directory libgnomecanvas-2.20.1.1, in which you will find debian/patches/90_upstream_correctly_update.patch. Rename (to something that doesn't end in .patch) or remove this file, and do a dpkg-buildpackage to get a libgnomecanvas without this bug.

[Pietro Battiston (toobaz)]

The "ubuntu-compiled package that was installed by default in intrepid" depends on which channels you have enabled, but notice that for instance in

http://packages.ubuntu.com/search?keywords=libgnomecanvas&searchon=names&suite=intrepid

you still get libgnomecanvas_2.20.1.1-1ubuntu2, which yes, has this bug.

Anyway: I tried to redownload (apt-get source libgnomecanvas) and recompile (dpkg-buildpackage -kfakeroot) the package, but I'm unable to reproduce the bug. May I ask you to attach the buggy binary (amd64, possibly?) recompiled by you, to try to see if I can reproduce it?

[Bob McElrath (bob+ubuntu)]

The package with the bug is:
    6f827fc1fffcbfa480dc548bb82b003a libgnomecanvas2-0_2.20.1.1-1ubuntu3_i386.deb
(that's the md5sum). I just re-downloaded it from the mirrors e.g.
    http://mirrors.kernel.org/ubuntu/pool/main/libg/libgnomecanvas/
and double checked. (i386 arch)

The package I compiled, simply removing 90_upstream_correctly_update.patch, and which does not have the bug, is attached.

This is not a -1ubuntu2 version misunderstanding.

[Pietro Battiston (toobaz)]

I'm trying to reproduce, and maybe a couple of times was successful, so I'm starting to think to some gcc misbehaviour (or, more realistically, some libgnomecanvas misbehaviour exposed only by some gcc)... does the bug also imply painful slowliness i.e. when resizing?

Andcor, do you have i386 too?

[Hpj-u (hpj-u)]

* PING *

Federico, any progress in this area? It's nagging me badly!

[legobib13 (legobib13)]

Hello,

I have been trying to get this debdiff to somehow patch my libgnomecanvas on openSUSE 11.1 x86_64. I can't do it. Is there any way I can? -- or is there a way a patch can be made for suse ?

I did upgrade my libgnomecanvas from shipped version 2.20.1.1-25.79 to 2.20.1.1-86.11 from http://download.opensuse.org/repositories/GNOME:/Factory:/Next/openSUSE_11.1/

Thanks.

[Pietro Battiston (toobaz)]

As far as I know, the fact that a SUSE corresponding bug is linked from here doesn't extend the scope of this page to how/which SUSE packages can be patched.

Also notice my patch didn't solve the problem for everybody. Anyway, you can find the patch itself in http://launchpadlibrarian.net/19312323/libgnomecanvas_2.20.1.1-1ubuntu3.debdiff
or
http://archive.ubuntu.com/ubuntu/pool/main/libg/libgnomecanvas/libgnomecanvas_2.20.1.1-1ubuntu3.diff.gz
, but they are not very friendly formats (for the not debian based)! Still, you can easily extract from it the real file.

Or you can go to the original Fedora bug from which I took the patch from.

[legobib13 (legobib13)]

I am new to the linux environment. How exactly would I go about extracting what I need? I noticed I can view a bunch of code in the .diff and .debdiff files, but I am not too familiar with much of it.

[Pietro Battiston (toobaz)]

I have absolutely _no_ idea of how a SUSE package must be patched (I don't even know how it must be compiled).

I'm not trying to be unpolite, I'm just trying to suggest that _this_ is not the right place to ask what you need.

[Vincenzo Ciancia (vincenzo-ml)]

legobib13: this is not the official suse bug tracker. Follow the link in the "assigned to" column for suse at the top of this page:

https://bugzilla.novell.com/show_bug.cgi?id=430785

and if the answer is not there, you may try to ask more information directly in the suse bug report.

[Hpj-u (hpj-u)]

* PING *

Are you still alive, Federico, or what else can _I_ do?

[Federico-9 (federico-9)]

Sigh, we dropped the patch *again*. I'll submit it for 11.1 and SLE-11. Thanks for the heads-up, Hans-Peter.

[Federico-9 (federico-9)]

Anja, I'd like to release this for openSUSE 11.1. Could I have a swampid, please?

[This should also be released for SLE-11, but we are collecting those fixes in bug #480414]

[Federico-9 (federico-9)]

The underlying code is exactly the same as for openSUSE 10.3 and 11.0, as there were no releases of libgnomecanvas in the meantime. The patch is the same as the one we shipped for those versions.

The problem is that I introduced a patch (libgnomecanvas-no-tearing.diff) originally, but it had a bug where it would repaint incorrectly. Later I fixed that bug and updated the patch in 10.3. However, when updating the package for 11.0 and 11.1, we somehow missed the updated patch and used the buggy/original one. This submission is for the fixed patch.

[Swamp-a (swamp-a)]

The SWAMPID for this issue is 23197.
Please submit the patch and patchinfo file using this ID.
(https://swamp.suse.de/webswamp/wf/23197)

[Federico-9 (federico-9)]

Thanks; submitted the patchinfo for openSUSE 11.1.

[Robert-alfaro (robert-alfaro)]

Hello,

  Sorry If I shouldn't be posting this here. I used the have this posted issue on 11.1 but I downgraded back to 11.0. My problem is that instead of having redrawing issues, my lines/writing in xournal appear jagged and not smooth. For example: If I have the page zoomed out and I write, then zoom in, everything is horribly jagged, however, if I zoom in a lot and write, it appears smooth and when I zoom out it looks ok. This is a hassle. Comparing the quality of writing from 11.1 and 11.0, 11.1 wins vastly. I am not sure whether it is a problem with libgnomecanvas. If anyone knows anything about this and could help me out or direct me to a bug report existing for this, I would highly appreciate this.

Thank you,
Robert

[Hpj-u (hpj-u)]

Dear Federico,

looks like the update didn't made it to the public servers so far.
Is there anything what can be done from outside?

Pete

[Federico-9 (federico-9)]

(In reply to comment #24)
> looks like the update didn't made it to the public servers so far.
> Is there anything what can be done from outside?

Hmm, it may be stuck in the updates process. In the meantime, you can get a built package from my repository in the build service:

http://download.opensuse.org/repositories/home://federico-mena://branches://openSUSE://11.1/standard/

[Hpj-u (hpj-u)]

Yup, thanks.

It's running well now -> VERIFIED (hopefully also in the next release.. ;-)

..as long as Novell doesn't manage to break SUSE into pieces. This company strongly annoy me at the moment (drop more work on less shoulders of already overloaded people is ... completely silly, even in these times!). Oh well..

[Swamp-a (swamp-a)]

Update released for: libgnomecanvas, libgnomecanvas-devel, libgnomecanvas-doc, libgnomecanvas-lang
Products:
openSUSE 11.1 (debug, i586, ppc, ppc64, x86_64)

[Bob McElrath (bob+ubuntu)]

This bug is still present in Jaunty and libgnomecanvas 2.26.

Unfortunately, the patch I removed from 2.20 to fix it is no longer present in 2.26. It looks like the libgnomecanvas people made the situation worse and incorporated the bug upstream.

The symptom is that what is drawn lags substantially behind the stylus, so much so that curved lines become joined line segments. It gets worse as you move to the bottom of the screen. It's more noticeable in portrait mode. Also, the effect is substantially worse than in Hardy. Xournal is basically unusable under Jaunty, unless you write REALLY slowly.

[Ken Arnold (kenneth-arnold)]

I actually have not seen this bug in a long time (though admittedly I don't
use xournal much these days).

"Works for me" with latest Jaunty.
xournal/jaunty uptodate 0.4.2.1-0.1ubuntu1
libgnomecanvas2-0/jaunty uptodate 2.26.0-0ubuntu1
libgnomecanvas2-common/jaunty uptodate 2.26.0-0ubuntu1
libgnomecanvasmm-2.6-1c2a/jaunty uptodate 2.23.1-1

I tried most combinations of settings within xournal that I could think of.
Try making a temporary new user account and running it there?

-Ken

On Tue, Apr 28, 2009 at 9:57 AM, Bob McElrath
<<email address hidden><bob%<email address hidden>>
> wrote:

> This bug is still present in Jaunty and libgnomecanvas 2.26.
>
> Unfortunately, the patch I removed from 2.20 to fix it is no longer
> present in 2.26. It looks like the libgnomecanvas people made the
> situation worse and incorporated the bug upstream.
>
> The symptom is that what is drawn lags substantially behind the stylus,
> so much so that curved lines become joined line segments. It gets worse
> as you move to the bottom of the screen. It's more noticeable in
> portrait mode. Also, the effect is substantially worse than in Hardy.
> Xournal is basically unusable under Jaunty, unless you write REALLY
> slowly.
>
> ** Changed in: libgnomecanvas (Ubuntu)
> Status: Fix Released => Confirmed
>
> --
> [regression, intrepid] redraw problems, patches from fedora
> https://bugs.launchpad.net/bugs/272316
> You received this bug notification because you are a direct subscriber
> of the bug.
>

[Bob McElrath (bob+ubuntu)]

On further investigation, it seems this was caused by the dastardly iowait kernel bug:

http://bugzilla.kernel.org/show_bug.cgi?id=12309

I'm sure that one is in launchpad somewhere but I couldn't find it.

Trackerd was running in the background right after the upgrade, and because the kernel can't properly load-balance when IO is occuring, everything became extremely slow. The X process (not xournal) was consuming 100% cpu while drawing. The result, ironically was nearly the same symptoms as I saw before with this bug.

Killing trackerd fixed it.

I hope someone fixes this kernel bug soon, it's hitting me from every side...

[Bob McElrath (bob+ubuntu)]

In case anyone else looks here, the related launchpad bugs are:

https://bugs.launchpad.net/ubuntu/+source/tracker/+bug/131983 (trackerd makes system crawl)

https://bugs.launchpad.net/ubuntu/+source/linux-source-2.6.22/+bug/131094 (because of a kernel bug)

[Swamp-a (swamp-a)]

Update released for: libgnomecanvas, libgnomecanvas-32bit, libgnomecanvas-debuginfo, libgnomecanvas-debuginfo-32bit, libgnomecanvas-debuginfo-x86, libgnomecanvas-debugsource, libgnomecanvas-devel, libgnomecanvas-doc, libgnomecanvas-lang, libgnomecanvas-x86
Products:
SLE-DEBUGINFO 11 (i386, ia64, ppc64, s390x, x86_64)
SLE-DESKTOP 11 (i386, x86_64)
SLE-SDK 11 (i386, ia64, ppc64, s390x, x86_64)
SLE-SERVER 11 (i386, ia64, ppc64, s390x, x86_64)

[Bwiedemann (bwiedemann)]

This is an autogenerated message for OBS integration:
This bug (430785) was mentioned in
https://build.opensuse.org/request/show/7953 11.1 / libgnomecanvas