bugfix batch for Hardy's Claws Mail

[Colin Leroy-Mira]

Binary package hint: claws-mail

Hello,

As for (https://bugs.launchpad.net/bugs/208230), I've prepared a new batch of patches coming from CVS since last time.
It contains fixes since 3.3.1cvs48 (which is where we were for bug 208230) until 3.4.0cvs99. Most of these fixes are important (crashers), a few are convenient.

Hope this helps,
Colin

[Colin Leroy-Mira (colin-colino)]

Here are the patches, in debdiff form. It should make things rather straightaway!
Details can be found in debian/changelog and each patch's header.

[Colin Leroy-Mira (colin-colino)]

Here's a more in-depth explanation of the fixed bugs:
- bug 1553: Select an email, choose Message/Mark/Lock - it should prevent deleting of this mail. Now select three emails including the locked one and choose Message/Move to trash. The locked email is deleted although it shouldn't.
- bug 1589: Leaves a file describing tags applied to messages when removing a folder. If recreating a folder with the same name, messages in it can get "phantom tags" applied to them.
- bug 1599: If an email contains more than one attachment with the same name ("photo.jpg" for example), dragging them one by one to the attachments part of a Compose window will make the sent mail contain N times the same file instead of N different files with the same name.
- bug 1602: If the user accepts to send a return receipt for a mail with an empty subject, Claws crashes
- bug 1610: Opening the Themes page of Preferences can cause a crash when closing the preferences window due to a dangling pointer.
- bug 1615: if using as signature file a FIFO like "signify --kill --fifo=$HOME/.signature" and signify isn't started, Claws will hang undefinitely waiting for an available read on the FIFO
- bug 1635: if switching from one account to another, and both have an automatic signature set, the very last character before the signature delimiter ("-- ") gets eaten.
- bug 1636: IMAP "NoSelect" folders, which can only contain folders, have the Properties item of their contextual menu greyed out, preventing to change a property and apply it to subfolders.
- Debian bug 481556: Lack of verification of a gpgme function return code can cause a crash when verifying a signature with "Ambiguous name" status.
- fix SIGXFSZ: Claws Mail can crash getting a SIGXFSZ signal after a long uptime when the network protocol log file reaches the filesystem's maximum.
- IMAP fixes: There were bugs related to error handling in IMAP code, that caused double-frees when a session got disconnected (by peer or network problems).

[Colin Leroy-Mira (colin-colino)]

These don't need to be applied to the Intrepid packages, as upstream will release 3.5.0 next week and it'll be in time to sync it to Debian then Ubuntu.

[Colin Leroy-Mira (colin-colino)]

Update debdiff to have a correct SRU version.

[Cesare Tirabassi (norsetto)]

Any reasons why this is still unanswered from motu-sru?

[Scott Kitterman (kitterman)]

Just I think no one got to it yet.

[Cesare Tirabassi (norsetto)]

If anyone wants to look at this please do. I can follow up the sru myself if it is needed.
I'm trying to get 3.5.0 into intrepid but at the moment it ftbfs since libtool wants libdb4.6, I'm trying to patch that to libdb4.7 (hoping it won't break it, do you have any idea Colin?).

[Colin Leroy-Mira (colin-colino)]

On 12 July 2008 at 10h07, Cesare Tirabassi wrote:

Hi,

> If anyone wants to look at this please do. I can follow up the sru
> myself if it is needed. I'm trying to get 3.5.0 into intrepid but at
> the moment it ftbfs since libtool wants libdb4.6, I'm trying to patch
> that to libdb4.7 (hoping it won't break it, do you have any idea
> Colin?).

I don't think that'll be a problem...

--
Colin

[Cesare Tirabassi (norsetto)]

Thanks for confirming Colin.
I will upload shortly a new libetpan which will fix this issue.

There is still one remaining though, which is the subject of bug 247909.
You have rejected this one upstream already (I think quite rightly), so, I'm not very keen in uploading it with the fix I attach. This means we will have to wait if and until libgtk is fixed in main though.

If you want to add any comment, please do so in that bug.

[Cesare Tirabassi (norsetto)]

clawsmail 3.5.0-2 is in Intrepid now:

https://launchpad.net/ubuntu/+source/claws-mail/3.5.0-2ubuntu1

If anyone can process the sru please do (note that this will close at least bug 213960).

[Cesare Tirabassi (norsetto)]

claws-mail (3.5.0-2ubuntu1) intrepid; urgency=low

  * Merge from debian unstable, remaining changes:
    - debian/patches/12disable_can_change_accels_by_default:
      the gtk_can_change_accels pref which allows to change keyboard shortcuts
      from Gtk+ menus default to false for consistence with the GNOME default
      and other UME apps.
    - Modify Maintainer value to match the DebianMaintainerField
      specification.
  * Add debian/patches/13fix_ftbfs_with_gtk+-2.13.x.patch:
    fix build failure with gtk+2.13.x (LP: #247909)
    http://www.colino.net/claws-mail/getpatchset.php?ver=3.5.0cvs10

claws-mail (3.5.0-2) unstable; urgency=low

  * debian/control
  - Fix libclaws-mail-dev section to match override file
  - Fix spelling-error-in-description (thanks lintian)
  - Fix -i18n description to reflect only available languages

claws-mail (3.5.0-1) unstable; urgency=low

  * New upstream release
  - Fixes pending bugs:
  - Segfault verifying a GPG signature (Closes: #481856)
  - Reply with quote doesn't include message (Closes: #486889)
  - Double free segfault denying SSL certificate (Closes: #481381)
  * patches/09use_x_www_browser.patch
  - Fixed format for dpkg-source (quilt format) (Closes: #485327)
  * debian/control
  - Updated standards version
  * patches/10*.patch, patches/series, debian/README.Debian
  - Removed patch, provided by new upstream autofaces feature

 -- Cesare Tirabassi < <email address hidden>> Sat, 12 Jul 2008 12:21:29 +0200

[Cesare Tirabassi (norsetto)]

3.5.0-2ubuntu1 is available through hardy backports now.