alsa/sdw: support soundwire audio for TGL-H machines

Bug #1911830 reported by Hui Wang
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HWE Next
Fix Released
Undecided
Unassigned
linux-firmware (Ubuntu)
Fix Released
High
Unassigned
Focal
Fix Released
High
Hui Wang
Groovy
Fix Released
High
Unassigned
Hirsute
Fix Released
High
Unassigned
linux-oem-5.10 (Ubuntu)
Invalid
Critical
Hui Wang
Focal
Fix Released
Critical
Hui Wang
linux-oem-5.13 (Ubuntu)
Invalid
Undecided
Unassigned
Focal
Fix Released
Undecided
Unassigned

Bug Description

[Impact]
In the OEM project, we have a new TGL-H soundwire machine, with
the current oem-5.10 kernel, the audio can't work.

[Fix]
Backport 6 patches from Intel thesofproject kernel.

[Test]
Put the testing sof-tgl-h.ri in the /lib/firmware/intel/sof,
boot the patched kernel, we could see speakers and microphone
from gnome-setting, and they all work well.

[Where problems could occur]
The patches changed soundwire machine driver, it is possible
to make the audio on old soundwire machines not work anymore.
But we tested the patches on TGL-U and cml soundwire machines,
all worked well.

Hui Wang (hui.wang)
affects: linux-oem-osp1 (Ubuntu) → linux-oem-5.10 (Ubuntu)
Changed in linux-oem-5.10 (Ubuntu):
importance: Undecided → Critical
status: New → In Progress
Changed in linux-oem-5.10 (Ubuntu Focal):
importance: Undecided → Critical
status: New → In Progress
tags: added: oem-priority originate-from-1908337 somerville
Hui Wang (hui.wang)
description: updated
Hui Wang (hui.wang)
Changed in linux-oem-5.10 (Ubuntu Focal):
assignee: nobody → Hui Wang (hui.wang)
Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

@hui.wang

I haven't seen the change in oem-5.10-next, can you help to SRU it?

Revision history for this message
Hui Wang (hui.wang) wrote :

Timo merged the SRU Jan 21.

Timo Aaltonen (tjaalton)
Changed in linux-oem-5.10 (Ubuntu Focal):
status: In Progress → Fix Committed
Changed in linux-oem-5.10 (Ubuntu):
status: In Progress → Invalid
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-focal
Revision history for this message
Hui Wang (hui.wang) wrote :

Installed the 5.10.0-1012-oem kernel on the Dell TGL-H machine with soundwire audio, the speaker, headphone, internal mic and headset-mic all worked well.

verified done.

tags: added: verification-done-focal
removed: verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-oem-5.10 - 5.10.0-1013.14

---------------
linux-oem-5.10 (5.10.0-1013.14) focal; urgency=medium

  * focal/linux-oem-5.10: 5.10.0-1013.14 -proposed tracker (LP: #1914024)

  * Fix no video output when boot up system with type-c port (LP: #1914020)
    - drm/i915/tgl: Fix typo during output setup

 -- Timo Aaltonen <email address hidden> Mon, 01 Feb 2021 12:47:03 +0200

Changed in linux-oem-5.10 (Ubuntu Focal):
status: Fix Committed → Fix Released
Hui Wang (hui.wang)
tags: added: originate-from-1913248
no longer affects: linux-oem-5.10 (Ubuntu Groovy)
no longer affects: linux-oem-5.10 (Ubuntu Hirsute)
Changed in linux-firmware (Ubuntu Focal):
status: New → In Progress
Changed in linux-firmware (Ubuntu Groovy):
status: New → In Progress
Changed in linux-firmware (Ubuntu Hirsute):
status: New → In Progress
Changed in linux-firmware (Ubuntu Focal):
importance: Undecided → High
Changed in linux-firmware (Ubuntu Groovy):
importance: Undecided → High
Changed in linux-firmware (Ubuntu Hirsute):
importance: Undecided → High
Changed in linux-firmware (Ubuntu Focal):
assignee: nobody → Hui Wang (hui.wang)
Juerg Haefliger (juergh)
Changed in linux-firmware (Ubuntu Focal):
status: In Progress → Fix Committed
Changed in linux-firmware (Ubuntu Groovy):
status: In Progress → Fix Committed
Changed in linux-firmware (Ubuntu Hirsute):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-firmware - 1.196

---------------
linux-firmware (1.196) hirsute; urgency=medium

  * Rebase against git://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git
    3f026a2f13a8f130cde849168a111ec80f12e27b
    - silabs: add new firmware for WF200
    - brcm: Fix Raspberry Pi 4B NVRAM file
    - Add symlink for BananaPi M2 to brcmfmac43430-sdio config
    - WHENCE: add missing symlink for BananaPi M3
    - rtw89: 8852a: add firmware v0.9.12.2
    - linux-firmware: add frimware for mediatek bluetooth chip (MT7921)
    - Mellanox: Add new mlxsw_spectrum firmware xx.2008.2406
    - iwlwifi: update 7265D firmware
    - iwlwifi: update 9000-family firmwares
    - iwlwifi: add new FWs from core59-66 release
    - rtw88: 8822c: Update normal firmware to v9.9.6
    - linux-firmware: Update firmware file for Intel Bluetooth AX201
    - linux-firmware: Update firmware file for Intel Bluetooth AX200
    - linux-firmware: Update firmware file for Intel Bluetooth AX210
    - amdgpu: add initial support for navy flounder
    - amdgpu: update raven firmware for 20.50
    - amdgpu: update raven2 firmware for 20.50
    - amdgpu: update navi10 firmware for 20.50
    - amdgpu: update renoir firmware for 20.50
    - amdgpu: update vega10 firmware for 20.50
    - amdgpu: update navi12 firmware for 20.50
    - amdgpu: update vega12 firmware for 20.50
    - amdgpu: update navi14 firmware for 20.50
    - amdgpu: update picasso firmware for 20.50
    - amdgpu: update vega20 firmware for 20.50
    - amdgpu: update sienna cichlid firmware for 20.50
    - rtl_bt: Update RTL8822C BT(UART I/F) FW to 0x59A_76A3
  * alsa/sdw: support soundwire audio for TGL-H machines (LP: #1911830)
    - SAUCE: sof-firmware: add TGL-H firmware from sof-bin v1.6.1

 -- Seth Forshee <email address hidden> Wed, 31 Mar 2021 13:49:18 -0500

Changed in linux-firmware (Ubuntu Hirsute):
status: Fix Committed → Fix Released
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello Hui, or anyone else affected,

Accepted linux-firmware into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/linux-firmware/1.190.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Timo Aaltonen (tjaalton) wrote :

Hello Hui, or anyone else affected,

Accepted linux-firmware into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/linux-firmware/1.187.11 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Chris Halse Rogers (raof) wrote : Update Released

The verification of the Stable Release Update for linux-firmware has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-firmware - 1.187.11

---------------
linux-firmware (1.187.11) focal; urgency=medium

  * Add in-tree Realtek 8821CE wireless module support (LP: #1885862)
    - rtw88: RTL8821C: Update firmware to v24.8

  * alsa/sdw: support soundwire audio for TGL-H machines (LP: #1911830)
    - SAUCE: sof-firmware: add TGL-H firmware from sof-bin v1.6.1

 -- Seth Forshee <email address hidden> Wed, 31 Mar 2021 15:34:04 -0500

Changed in linux-firmware (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Chris Halse Rogers (raof) wrote :

Urgh. I've accidentally released linux-firmware to focal without verification, and without waiting for the groovy task to be done. Hui, can you please test this for focal and groovy? Thanks.

Revision history for this message
Hui Wang (hui.wang) wrote :

Installed the linux-firmware (1.187.11) on a Lenovo TGL-H machine yesterday, the sof audio driver worked very well.

Verification done on the linux-firmware focal.

Revision history for this message
Hui Wang (hui.wang) wrote :

Installed the linux-firmware (1.190.4) on a Dell TGL-H machine, the audio worked very well.

Verification done on the linux-firmware groovy.

thx.

tags: added: verification-done-groovy
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-firmware - 1.190.4

---------------
linux-firmware (1.190.4) groovy; urgency=medium

  * Fix stale brcmfmac43455-sdio.raspberrypi,3-model-a-plus.txt symlink
    (LP: #1918698)
    - brcm: Fix a stale symlink for RPi3 model b+

  * alsa/sdw: support soundwire audio for TGL-H machines (LP: #1911830)
    - SAUCE: sof-firmware: add TGL-H firmware from sof-bin v1.6.1

 -- Seth Forshee <email address hidden> Wed, 31 Mar 2021 14:41:15 -0500

Changed in linux-firmware (Ubuntu Groovy):
status: Fix Committed → Fix Released
Changed in linux-oem-5.13 (Ubuntu):
status: New → Invalid
Changed in hwe-next:
status: New → Fix Released
status: Fix Released → Triaged
Hui Wang (hui.wang)
Changed in linux-oem-5.13 (Ubuntu Focal):
status: New → Fix Released
Timo Aaltonen (tjaalton)
Changed in hwe-next:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.