Stale firmware symlink

[Juerg Haefliger]

[Impact]

On Groovy with linux-firmware 1.190.3:

lrwxrwxrwx 1 root root 54 Jan 7 15:40 brcmfmac43455-sdio.raspberrypi,3-model-a-plus.txt -> brcm/brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt

That link target is wrong and doesn't exist, it should be without the 'brcm/' prefix.

[Test Case]

$ ls -la /lib/firmware/brcm/brcmfmac43455*

[Fix]

The upstream fix is:

commit a9993f8d3b241f70a691a5b81bf2cdb442c0e184
Author: Takashi Iwai <email address hidden>
Date: Tue Sep 8 12:16:56 2020 +0200

    brcm: Fix a stale symlink for RPi3 model b+

    The symlink for brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt
    was wrongly listed with the same subdirectory brcm, and this resulted
    in a stale symlink. Fix it.

    Signed-off-by: Takashi Iwai <email address hidden>
    Signed-off-by: Josh Boyer <email address hidden>

[Where Problems Could Occur]

Firmware is now loaded on Pi 3A+ at boot which didn't happen before so theoretically that could crash the kernel if it's buggy.

[Timo Aaltonen (tjaalton)]

Hello Juerg, or anyone else affected,

Accepted linux-firmware into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/linux-firmware/1.190.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Juerg Haefliger (juergh)]

Tested linux-firmware 1.190.4. Looks good.

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux-firmware - 1.190.4

---------------
linux-firmware (1.190.4) groovy; urgency=medium

  * Fix stale brcmfmac43455-sdio.raspberrypi,3-model-a-plus.txt symlink
    (LP: #1918698)
    - brcm: Fix a stale symlink for RPi3 model b+

  * alsa/sdw: support soundwire audio for TGL-H machines (LP: #1911830)
    - SAUCE: sof-firmware: add TGL-H firmware from sof-bin v1.6.1

 -- Seth Forshee <email address hidden> Wed, 31 Mar 2021 14:41:15 -0500

[Timo Aaltonen (tjaalton)]

The verification of the Stable Release Update for linux-firmware has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.