And then yes, I think we should adapt the code to also check the snippets :(
Thanks for the through checks you did on your review.
As per a) and c2), I wanted to keep things as simplest as possible without worrying too much about handling edge cases that are not valid for our scenario. Indeed having something better than posix sh would have been nice... Indeed one option could be even using the very same libini to write a simple c tool that does it instead of relying on more complex shell code.
I'm fine with b) and c). Indeed IIRC they were not a big deal in my tests nor causing any error msg, but I may have missed a case.
So... I indeed was considering the config snippets but the versioning tricked me.
I don't think that libini 1.3.0 was ever released as such... In fact that's https:/ /github. com/SSSD/ ding-libs/ tree/master/ ini
But looking at the packaging in fedora, it seems they're hardcoded such version there: https:/ /src.fedoraproj ect.org/ rpms/ding- libs/blob/ rawhide/ f/ding- libs.spec# _17
And then yes, I think we should adapt the code to also check the snippets :(
Thanks for the through checks you did on your review.
As per a) and c2), I wanted to keep things as simplest as possible without worrying too much about handling edge cases that are not valid for our scenario. Indeed having something better than posix sh would have been nice... Indeed one option could be even using the very same libini to write a simple c tool that does it instead of relying on more complex shell code.
I'm fine with b) and c). Indeed IIRC they were not a big deal in my tests nor causing any error msg, but I may have missed a case.