[snap] launchers in app's dock menu do launch general LO

Bug #1902148 reported by Francois Thirioux
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libreoffice (Ubuntu)
Medium
Heather Ellsworth
Focal
Undecided
Heather Ellsworth

Bug Description

LO 7.0.2
Ubuntu Focal

1) right-click on LO icon in dock (white LO icon which does launch the home page with apps and recent docs)
2) select e.g. Calc

It does launch general LO (home page with apps and recent docs), not Calc.

Revision history for this message
Heather Ellsworth (hellsworth) wrote :

Thank you for reporting your bug to help make Ubuntu better!

Help me understand a little bit what is going on.. assuming you have the LO snap installed and no LO debs (just to avoid any confusion), if you right click on the Calc icon, you do not see Calc open up - is that right?

Revision history for this message
Francois Thirioux (fthx) wrote :

Right, every right click menu shortcut launches the same app as left click on LO global launcher (the white one). Only LO snap installed.

Revision history for this message
Francois Thirioux (fthx) wrote :

Ok I got it.
In:
/snap/libreoffice/current/meta/gui
there is the launcher libreoffice.desktop.

Unfortunately it contains bad actions launchers, as far as I understand that:

Actions=Writer;Calc;Impress;Draw;Base;Math;

[Desktop Action Writer]
Name=Writer
Exec=libreoffice

[Desktop Action Calc]
Name=Calc
Exec=libreoffice

[Desktop Action Impress]
Name=Impress
Exec=libreoffice

[Desktop Action Draw]
Name=Draw
Exec=libreoffice

[Desktop Action Base]
Name=Base
Exec=libreoffice

[Desktop Action Math]
Name=Math
Exec=libreoffice

Revision history for this message
Heather Ellsworth (hellsworth) wrote :

Ah yes this is it!

I've added a fix that is building now:
https://code.launchpad.net/~hellsworth/+snap/libreoffice-1902148

Once complete, it should upload to the store under a branch called lp-1902148 for testing.

Changed in libreoffice (Ubuntu):
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Heather Ellsworth (hellsworth)
Revision history for this message
Francois Thirioux (fthx) wrote :

Well, the build has failed?
So is the store branch lp-1902148 active?
(I saw a former commit, I'll get LZO too?)

Revision history for this message
Heather Ellsworth (hellsworth) wrote :

Yeah.. I was sure this would work because i tested my addition locally in a little quick script. I reran the lp build and it failed in the same way (good to know it's consistent). I did a local build last night and ran out of memory becuase libreoffice is a beast so I'll try again on an unused system to try and debug why it's failing..

Revision history for this message
Sebastien Bacher (seb128) wrote :

Which interpreter did you try in your local script? Doing

'#!/bin/sh
set -x
for app in base calc draw
            do
                App="${app^}"
                sed -i \
                    -e "s#Icon=libreoffice7.0-$app#Icon=/usr/share/icons/gnome/256x256/apps/libreoffice7.0-$app.png#" \
                    -e "s#^Exec=libreoffice7.0 --\(.*\)#Exec=libreoffice.\1#g" \
                    -e "/^Name=$App$/{$!{N;s/^Name=$App\nExec=libreoffice$/Name=$App\nExec=libreoffice.$app/;ty;P;D;:y}}" \
                    /tmp/$app.desktop
            done'

returns the same bad substitution error

Revision history for this message
Heather Ellsworth (hellsworth) wrote :

There were a couple of issues with my sed. I reproduced the issue locally and believe that I have fixed it and it's building on lp now.

https://code.launchpad.net/~hellsworth/+snap/libreoffice-1902148

Revision history for this message
Heather Ellsworth (hellsworth) wrote :

Ok well I've been going down a rabbit hole here, trying to fix /meta/gui/libreoffice.desktop. There is a strange problem here.. I don't know what is creating libreoffice.desktop instead of using the startcenter.desktop file that should fix the issue.

However.. In my testing and comparison to the debs, I came across https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1696250 which removed the startcenter and math icons all together. This was done as a cosmetic change really. However since we'd like to see the snap behave *just like* the deb, I will just remove these icons as well from the snap.

Revision history for this message
Adolfo Jayme (fitojb) wrote :

I am fully against hiding any LibreOffice icons from the Shell.

tags: added: rls-ff-incoming
Changed in libreoffice (Ubuntu Focal):
assignee: nobody → Heather Ellsworth (hellsworth)
Revision history for this message
Heather Ellsworth (hellsworth) wrote :

After some discussion weighing the pros/cons of removing the icons from the snap, we decided that it's best to keep the icons to keep the snap as close to the upstream package as possible.

tags: removed: rls-ff-incoming
Revision history for this message
Sebastien Bacher (seb128) wrote :

The most recent activity suggests it's wontfix?

Changed in libreoffice (Ubuntu Focal):
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers