> Thanks Marco, that looks great but it's a bit late now for such change. We should probably try to get that into a SRU once it has been reviewed upstream, what do you think?
Yeah, given that the change was not a small one, I was expecting to be more SRU material at this point.
Nevertheless I'm quite confident with this code as it has been tested quite heavily, but indeed I'd prefer not to be too different to what I'd like to have upstream as well.
> If we do postpone should we include at least the bump of the enroll counter suggested in comment #8?
Ok, I can look at that as well; that would only fix the "no-dialog" shown issue, though while not the ability to enroll multiple fingers to have a proper identification (in the current state only the first finger, in no clear order is considered).
> Thanks Marco, that looks great but it's a bit late now for such change. We should probably try to get that into a SRU once it has been reviewed upstream, what do you think?
Yeah, given that the change was not a small one, I was expecting to be more SRU material at this point.
Nevertheless I'm quite confident with this code as it has been tested quite heavily, but indeed I'd prefer not to be too different to what I'd like to have upstream as well.
> If we do postpone should we include at least the bump of the enroll counter suggested in comment #8?
Ok, I can look at that as well; that would only fix the "no-dialog" shown issue, though while not the ability to enroll multiple fingers to have a proper identification (in the current state only the first finger, in no clear order is considered).
However I'd say we also need /gitlab. gnome.org/ GNOME/gnome- control- center/ -/merge_ requests/ 727
https:/
As some divers might cause hanging.