Comment 25 for bug 1865226

Sorry, I missed the previous comments.

> Do I read the gnome-settings-daemon patches correctly, and this actually just entirely drops support for auth via NSS? So the regression potential is that if someone has set up auth via a custom system nss database, this *will* break login for them?

Well, yes that's a regression potential that may indeed be mentioned, it's also something that we never supported though, since that required some extra setup in various places (write a gdm pam configuration, create the NSS database and configure pam-pkcs11/pam_sss). But indeed it could potentially affect someone who went through all this.

However... The SSSD side of this (lp:1905790), if one had configured a NSS database in the canonical location, it will be migrated (using this tool https://github.com/3v1n0/nss-database-pem-exporter).

So, it's quite a remote possibility but worth to mention in a clearer way (it was somewhat written already).

> Unrelatedly, patches like smartcard-Use-autopointers.patch and smartcard-manager-Use-mutex-auto-lockers-when-convenient.patch are the sort of refactoring patches that we prefer not to see in SRUs. I don't think they're a blocker, but they make reviewing more difficult

Let me know if I should drop them, one reason why they were added is that they were part of the upstream changes too, and so it made easier to ensure that we're both in the same line if problems may happen, making easier to backport patches in future if needed.