Comment 6 for bug 121780

Description of problem:

The funcion process_client in cman/daemon.c uses a static buffer
of size MAX_CLUSTER_MESSAGE + sizeof(struct sock_header).
MAX_CLUSTER_MESSAGE is 1500 bytes and struct sock_header at the timing of filing
this bug is 20 bytes.

2 problems are discovered here and fixed by the patch committed to head (see url).

The buffer is never cleaned and so data from previous usage will stay in the new
one.

There is no upper boundary check if the data we are reading from the socket are
larger than the buffer itself.

It was fairly simple to connect to cman and push a random 1520 bytes in the
socket that will corrupt memory and eventually crash cman/aisexec.

How reproducible:

always

Additional info:

cvs HEAD has been fixed but i am told to submit a BZ for people to look into the
different release branches.

Patrick has been informed and agreed on the solution on CVS head.

Submitting the bug on Lon request.