Comment 15 for bug 1891202

Revision history for this message
Christian Ehrhardt  (paelzer) wrote : Re: [Bug 1891202] Re: Multipathd hangs with long iscsi target names in Ubuntu 18.04

On Wed, Oct 28, 2020 at 7:11 PM Robie Basak <email address hidden>
wrote:

> > + len = buff_len < 8 ? -ENODATA :
> > + (buff_len <= maxlen ? buff_len : maxlen);
> > + memcpy (str, buff, len);
>
> This looked concerning to me. There's a code path that will call memcpy
> with a len of -ENODATA which seemed quite dangerous to me.
>
>
Great catch Robie,
I'll incorporate that.