Precedence bug in patch
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
linux (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Dapper |
Invalid
|
Undecided
|
Unassigned | ||
linux-source-2.6.15 (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
Dapper |
Fix Released
|
Medium
|
Colin Ian King | ||
linux-source-2.6.17 (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
Dapper |
Invalid
|
Undecided
|
Unassigned |
Bug Description
Binary package hint: linux-source-2.6.15
When compiling linux-source, I got an unexpected warning, which turned out to be caused by these two commits (links are per Dapper and Edgy):
http://
http://
In particular, since '>>' has lower precedence than +, the below hunk doesn't do what it wants to do. I've not tested which bad things can happen, but it warrants a fix. In fact, in mainline the missing parentheses have been added - see commit ac924c6034d9095
@@ -2462,8 +2464,8 @@ void setup_per_
}
- zone->pages_low = zone->pages_min + tmp / 4;
- zone->pages_high = zone->pages_min + tmp / 2;
+ zone->pages_low = zone->pages_min + tmp >> 2;
+ zone->pages_high = zone->pages_min + tmp >> 1;
}
}
Related branches
Changed in linux-source-2.6.17: | |
assignee: | nobody → kernel-team |
Changed in linux-source-2.6.15: | |
assignee: | nobody → kernel-team |
Changed in linux-source-2.6.15: | |
assignee: | kernel-team → ubuntu-kernel-team |
Changed in linux-source-2.6.17: | |
assignee: | kernel-team → ubuntu-kernel-team |
Changed in linux: | |
status: | New → Invalid |
Changed in linux-source-2.6.15: | |
assignee: | nobody → ubuntu-kernel-team |
importance: | Undecided → Medium |
status: | New → Triaged |
Changed in linux-source-2.6.17: | |
status: | New → Invalid |
Changed in linux: | |
status: | Confirmed → Fix Released |
Changed in linux-source-2.6.15: | |
assignee: | ubuntu-kernel-team → colin-king |
milestone: | none → dapper-updates |
status: | Triaged → In Progress |
Changed in linux-source-2.6.15: | |
status: | Confirmed → Invalid |
This is the needed patch. Btw, to trigger this problem it seems you need to fiddle with /proc.