Comment 3 for bug 86778

Revision history for this message
Blaisorblade (p-giarrusso) wrote :

It applies to 6.06 LTS, so it is still relevant. And it's trivial to solve (for a kernel developer it should take two minutes to agree with me, IMHO; I'm a kernel developer too).

Back on the issue: it is trivial to solve. Look at the patch you merged (updated URL):
http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-dapper-updates.git;a=commitdiff;h=622f7b4c920a9362d506400c0da02e3e06442b27

and at the patch merged in mainline:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ac924c6034d9095f95ee889f7e31bbb9145da0c2

The bug I mention was corrected before merging in mainline, so you can fix it with confidence, too. And by reading the hunk I mentioned it's clear that the new code, without parentheses, is wrong, because it should do the same thing as the old code.

A note on what you say: the patch is not "extrinsic to standard delivery channels", it is part of the kernel you package, and is not a "compile issue". It is a real bug (and the warning from the compiler points this out). That patch has been shipped in Dapper & Edgy kernel packages for a long time. The GIT tree I linked is where all development on Ubuntu kernels is tracked (GIT is a Version Control System, similar to CVS, Subversion etc...). I must suppose you are not a kernel developer. Well, then I'll mention that I've been a kernel developer for quite a bit of time so, at the very least, I know what I am talking about.