Comment 1 for bug 1814118

Revision history for this message
Ɓukasz Zemczak (sil2100) wrote :

The package looks good and I guess I'll just sponsor it as is. For a moment I was wondering about proposing a small change to the relevant patch: since currently when we're able to open /proc/device-tree/system/linux,revision but are not able to read the contents, the patch forces an error. Was thinking that maybe we should fall-back to the cpuinfo check in this case as well. But then, I suppose that if the linux,revision is openable but unreadable, that's actually a bug and maybe one should actually error out. Besides, this might make the code less clean as for handling an edge-case. Might be worth considering, but I now lean towards just releasing this to disco as-is.