Comment 15 for bug 1825049

Revision history for this message
Leon Miller-Out (v-leon) wrote : Re: [Bug 1825049] Re: dnsimple adapter produces invalid URL in create_record

Yes, of course!

I installed python3-lexicon 2.2.1-2ubuntu0.1 from bionic-proposed:
$ sudo apt list python3-lexicon
Listing... Done
python3-lexicon/bionic-proposed,bionic-proposed,now 2.2.1-2ubuntu0.1 all
[installed]

I verified that the single-character fix is now included in the new version
of /usr/lib/python3/dist-packages/lexicon/providers/dnsimple.py. I also ran
the program that was leveraging the broken method and verified that it no
longer reports an error created by the malformed URL.

Thanks so much for working on this backport!

On Thu, May 16, 2019 at 10:05 AM Robie Basak <email address hidden>
wrote:

> Leon, please could you confirm exactly what testing you performed and
> the exact package version number of the package that you tested? This
> information helps us avoid mistakes, such as anything specific that we
> think should be verified being missed. Otherwise we cannot make any
> judgement as to whether the testing that has been performed is
> sufficient, which is required to release the package to the updates
> pocket.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1825049
>
> Title:
> dnsimple adapter produces invalid URL in create_record
>
> Status in lexicon package in Ubuntu:
> Fix Released
> Status in lexicon source package in Bionic:
> Fix Committed
> Status in lexicon source package in Cosmic:
> Fix Committed
> Status in lexicon package in Debian:
> Fix Released
>
> Bug description:
> [racb: see comment 1 for SRU information; regression potential: likely
> to be in the DNSimpple.com API for DNS record creation; however there
> is good existing test coverage, including for this bug being added,
> which I think is sufficient for regression testing during SRU
> verification]
>
> The bug fixed by the following pull request is also present in lexicon
> v2.2.1-2, and the fix should be backported.
> https://github.com/AnalogJ/lexicon/pull/389/files?file-filters%5B%5D=.py
>
> This causes requests to the DNSimple.com API for DNS record creation
> to fail because the generated URL is ill-formed.
>
> Line 64 of is
> payload =
> self._post('{0}/zones/{1}/records'.format(self.account_id,
> self.options.get('domain')), record)
> but should be
> payload =
> self._post('/{0}/zones/{1}/records'.format(self.account_id,
> self.options.get('domain')), record)
>
> $ lsb_release -rd
> Description: Ubuntu 18.04.2 LTS
> Release: 18.04
>
> $ apt-cache policy lexicon
> lexicon:
> Installed: (none)
> Candidate: 2.2.1-2
> Version table:
> 2.2.1-2 500
> 500 http://mirror.rackspace.com/ubuntu bionic/universe amd64
> Packages
> 500 http://mirror.rackspace.com/ubuntu bionic/universe i386
> Packages
> 500 http://archive.ubuntu.com/ubuntu bionic/universe amd64
> Packages
> 500 http://archive.ubuntu.com/ubuntu bionic/universe i386
> Packages
>
> To manage notifications about this bug go to:
>
> https://bugs.launchpad.net/ubuntu/+source/lexicon/+bug/1825049/+subscriptions
>