Comment 55 for bug 1778322

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

> The original issue was you couldn't get a listing of samba hosts in Nautilus so
> yes that issue is fixed.

The original problem also affected linux samba boxes, which do allow smb1 by default still. You couldn't even see them in nautilus. Now you can, and you can browse their shares and connect to them.

> But why did we want to get the list in the first place? I would argue so that
> you could gain access to those hosts from the same process and here it only
> applies to hosts that still allow NT1 / SMB1.

I agree, and the fix we have here is a step in that direction. But the whole premise of being able to seamlessly connect to boxes that have SMB1 disabled is not where this started, and might require more troubleshooting. Depending on how complicated that is, I just wouldn't want to prevent users from getting this particular fix while the other part is being looked at.

That being said, I'll do some experiments with boxes that have SMB1 disabled and perhaps file a new upstream bug with gvfsd. But I think this very particular bug here in launchpad is fixed with the changes to samba and gvfsd that exist today.