Comment 5 for bug 1915304

Revision history for this message
Thadeu Lima de Souza Cascardo (cascardo) wrote :

Hi, Jason.

Thanks for pointing out the fix. I checked it and it wasn't going to work for either older or newer kernels, as we wanted the dkms to be able to be built against either of them.

As I have some experience doing that kind of check for other dkms packages, inspired by my previous work with openvswitch, I decided to work it out for this one-off case. Unfortunately, I don't have the time budget right now to do it extensively for all of wireguard-linux-compat, which would be a more acceptable solution for you as its upstream, I suppose.

As we haven't applied the referred linux commit yet, upstream wireguard-linux-compat still doesn't require a fix for building against Ubuntu kernels. As I understand it, once we ship something including that commit, it would break its build, and some solution would be necessary. May I suggest looking into using UTS_UBUNTU_RELEASE_ABI? Would that work for you?

Thanks for your work on wireguard.
Cascardo.