Comment 13 for bug 1781128

Revision history for this message
bugproxy (bugproxy) wrote : Comment bridged from LTC Bugzilla

------- Comment From <email address hidden> 2018-10-31 17:07 EDT-------
Will:

I don't seem to have an old Valgrind tree around that used the svn revision control to examine.

But according to my notes, the functional fix was committed in svn revision 395709 on June 21, 2018. The functional fix adds the support for the instruction to Valgrind and the support for the instruction to the functional test test_isa_2_06_part3.c to the test suite. However, the expected result file changes didn't get included in that commit.

It looks like Valgrind switched to the Git repository right after that. I see the expected results for the test case were committed in the git repository as:

commit 1f69ed86e994ee152a0e6e3ee7031d0105f02a7e
Author: Carl Love <email address hidden>
Date: Mon Jun 25 16:24:14 2018 -0500
Fix ppc32 results for test_isa_2_06_part3.c.
The ppc32 results were not updated when the xvnegsp instruction support
was added. Add the xvnegsp 32-bit results to
ppc/test_isa_2_06_part3.stdout.exp.

So, all of the functional Valgrind and test case changes went in on the first commit. Hopefully that clears up your question?

Carl Love