Comment 70 for bug 1854363

Revision history for this message
In , Kai Engert (kaie) wrote :

(In reply to Kai Engert (:kaie:) from comment #55)
> Maybe keep TranslateLDAPErrorToNSError(), and pass it to NotifyLDAPError()
> (multiple places), so it will be available when working on bug 1592449.

Looks like my suggestion is unnecessary, because NotifyLDAPError() has access to lderrno which can be used to obtain the failure.

> > + Conn()->AddPendingOperation(msgID, mOp);
>
> Could Conn() ever be null?

The previous code didn't check for null at this place, so we can skip that for now.

I'll make the single change that I consider necessary, and attach an updated revision, so Jörg can proceed.