Comment 31 for bug 1641308

Revision history for this message
Robie Basak (racb) wrote :

> * Regression potential
> check that partitions handling is still working correctly in g-d-u

Yes, but I think some more detail is required here. An accidental regression caused by this patch could lead to data loss.

Please see https://wiki.ubuntu.com/StableReleaseUpdates#Procedure - we need "a discussion of how regressions are most likely to manifest, or may manifest even if it is unlikely, as a result of this change" and (implied) thoughts towards specifically what needs to be tested based on that discussion.

I've accepted the patch into proposed as it seems correct and important to fix, but I don't think this should be accepted into bionic-updates after SRU verification until the documented regression mitigation steps are completed in full.