Comment 4 for bug 1854842

Hi Mohammad,

I had a look at the git repo for 4.15.0-72, which is the current kernel in -updates, to see what commits you mentioned in the description are already present.

Subject: net/mlx5e: Rx, Fix checksum calculation for new hardware
Commit: db849faa9bef993a1379dc510623f750a72fa7ce
In 4.15.0-72? No.

Subject: net/mlx5e: Rx, Check ip headers sanity
Commit: 0318a7b7fcad9765931146efa7ca3a034194737c
In 4.15.0-72? Yes. Arrived in 4.15.0-67.

Subject: net/mlx5e: Rx, Fixup skb checksum for packets with tail padding
Commit: 0aa1d18615c163f92935b806dcaff9157645233a
In 4.15.0-72? No.

Subject: net/mlx5e: XDP, Avoid checksum complete when XDP prog is loaded
Commit: 5d0bb3bac4b9f6c22280b04545626fdfd99edc6b
In 4.15.0-72? Yes. Arrived in 4.15.0-67.

Subject: mlx5: fix get_ip_proto()
Commit: ef6fcd455278c2be3032a346cc66d9dd9866b787
In 4.15.0-72? Yes. Arrived in 4.15.0-67.

Subject: net/mlx5e: Allow reporting of checksum unnecessary
Commit: b856df28f9230a47669efbdd57896084caadb2b3
In 4.15.0-72? Yes. Arrived in 4.15.0-67.

Subject: net/mlx5e: don't set CHECKSUM_COMPLETE on SCTP packets
Commit: fe1dc069990c1f290ef6b99adb46332c03258f38
In 4.15.0-72? Yes. Arrived in 4.15.0-67.

Subject: net/mlx5e: Set ECN for received packets using CQE indication
Commit: f007c13d4ad62f494c83897eda96437005df4a91
In 4.15.0-72? Yes. Arrived in 4.15.0-67.

Subject: net/mlx5e: Add likely to the common RX checksum flow
Commit: 63a612f984a1fae040ab6f1c6a0f1fdcdf1954b8
In 4.15.0-72? No.

Subject: net/mlx5e: CHECKSUM_COMPLETE offload for VLAN/QinQ packets
Commit: f938daeee95eb36ef6b431bf054a5cc6cdada112
In 4.15.0-72? Yes. Arrived in 4.15-rc1.

So it appears that most of these commits are already present in 4.15.0-72.

I had a look at the code for:

Subject: net/mlx5e: Add likely to the common RX checksum flow
Commit: 63a612f984a1fae040ab6f1c6a0f1fdcdf1954b8

This commit does not really fix anything, it is an optimisation. So we won't
worry about this commit any more.

Subject: net/mlx5e: Rx, Fix checksum calculation for new hardware
Commit: db849faa9bef993a1379dc510623f750a72fa7ce

This commit was selected for -upstream stable in 5.1.21 and 5.2.4.

Subject: net/mlx5e: Rx, Fixup skb checksum for packets with tail padding
Commit: 0aa1d18615c163f92935b806dcaff9157645233a

This commit was selected for -upstream stable in 4.19.76 and 5.0.10.

Those two commits really should have been applied to the bionic 4.15 kernel, but it seems they have been missed, probably due to not cleanly applying to the 4.15 tree.

I will try and backport these commits now, and build you a test kernel if I manage to successfully backport these patches.

I will write back shortly.

Matthew