Comment 4 for bug 1773704

Revision history for this message
Jeffrey Miller (mysterylectricity) wrote : Re: [Bug 1773704] Re: Typo at line 184 in xhci-pci.c makes trouble for Renesas USB chipset in Bionic 18.04

 Dear Mr. Salisbury,
I can't believe it's been 12 days since I filed this report. Seems like it was just yesterday. And in fact it's just today I found your missives. Shame on me!
I'm having a bad case of battle fatigue with this issue. I'm deploying like TODAY.  Do I live with errors? Do I compile my own kernel ( have done for 6 mos now)? Do I try your kernel? Do I live with errors until the typo  is fixed?
I hope you can trust me on this one, This is a single-character typo. Fix the typo, everything works fine.
The only question at this point is how to run it up the flagpole as quickly as possible. I suspect it's upstream of Ubuntu.
    On Tuesday, May 29, 2018, 11:51:15 AM PDT, Joseph Salisbury <email address hidden> wrote:

 ** Changed in: linux (Ubuntu Bionic)
    Assignee: (unassigned) => Joseph Salisbury (jsalisbury)

** Changed in: linux (Ubuntu)
    Assignee: (unassigned) => Joseph Salisbury (jsalisbury)

** Changed in: linux (Ubuntu Bionic)
      Status: Triaged => In Progress

** Changed in: linux (Ubuntu)
      Status: Triaged => In Progress

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/1773704

Title:
  Typo at line 184 in xhci-pci.c makes trouble for Renesas USB chipset
  in Bionic 18.04

Status in linux package in Ubuntu:
  In Progress
Status in linux source package in Bionic:
  In Progress

Bug description:
  A typo at line 184 in /drivers/usb/host/xhci-pci.c trashes a good fix.

  183        if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&
  184                        pdev->device == 0x0014)
  185                xhci->quirks |= XHCI_TRUST_TX_LENGTH;
  186        if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&
  187                        pdev->device == 0x0015)
  188                xhci->quirks |= XHCI_RESET_ON_RESUME;

  Line 184 should be identical to line 187, ie: should read pdev->device
  == 0x0015)

  I've compiled the kernel both with and without the typo. As written,
  hundreds of messages fill dmesg suggesting XHCI_TRUST_TX_LENGTH may be
  needed when zoneminder tries to access my USB webcams. With the fix
  applied as I've suggested the messages disappear.

  The typo is still present in 4.15.0-22.24

  For more background, you may refer to bug ID #1710548

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773704/+subscriptions