Comment 12 for bug 1773704

Revision history for this message
Jeffrey Miller (mysterylectricity) wrote : Re: [Bug 1773704] Re: Typo at line 184 in xhci-pci.c makes trouble for Renesas USB chipset in Bionic 18.04

 I wasn't able to test the kernel you provided, dpkg -i complained of conflicting packages. I suspect because the kernel was down-rev relative to the running kernel. But I don't reslly know, I'm relatively new to compilling and installing kernels.
However, I was able to compile and install my own kernel on the target machine. Once again, all I did was change line 184 to be identical to like 187 and it worked like a charm: no more errors.
So my suggestion was that if you made the exact same change, your test jernel _should_ work. But I can understand if that's just not the way it's done around here, and I'll be happy to test your kernel if I can get around the error message. Is there an option I can give to dpkg to force the installation?
-Jeff
    On Friday, July 27, 2018, 8:41:19 AM PDT, Joseph Salisbury <email address hidden> wrote:

 Sorry for the delay.  Just to confirm, the test kernel posted in comment
#3 did in fact resolve this bug?  If so, I'll submit an SRU request.

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/1773704

Title:
  Typo at line 184 in xhci-pci.c makes trouble for Renesas USB chipset
  in Bionic 18.04

Status in linux package in Ubuntu:
  In Progress
Status in linux source package in Bionic:
  In Progress

Bug description:
  A typo at line 184 in /drivers/usb/host/xhci-pci.c trashes a good fix.

  183        if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&
  184                        pdev->device == 0x0014)
  185                xhci->quirks |= XHCI_TRUST_TX_LENGTH;
  186        if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&
  187                        pdev->device == 0x0015)
  188                xhci->quirks |= XHCI_RESET_ON_RESUME;

  Line 184 should be identical to line 187, ie: should read pdev->device
  == 0x0015)

  I've compiled the kernel both with and without the typo. As written,
  hundreds of messages fill dmesg suggesting XHCI_TRUST_TX_LENGTH may be
  needed when zoneminder tries to access my USB webcams. With the fix
  applied as I've suggested the messages disappear.

  The typo is still present in 4.15.0-22.24

  For more background, you may refer to bug ID #1710548

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773704/+subscriptions