Comment 13 for bug 1698700
Revision history for this message
| Daniel Axtens (daxtens) wrote Re: [Bug 1698700] Re: hibmc driver does not include "pci:" prefix in bus ID | #13 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Hi Fred,
I will have a look soon and update you.
Regards,
Daniel
On Mon, Dec 11, 2017 at 6:00 PM, Fred Kimmy
<email address hidden> wrote:
> this patch will solve commit #10 bug, please merge this patch.
>
> thank you
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https:/
>
> Title:
> hibmc driver does not include "pci:" prefix in bus ID
>
> Status in linux package in Ubuntu:
> Incomplete
> Status in linux source package in Zesty:
> Fix Released
> Status in linux source package in Artful:
> Incomplete
>
> Bug description:
> SRU Justification
>
> [Impact]
> On the HiSilicon D05 (arm64) board, X crashes when started. [0]
>
> [Fix]
> The crash is attributable to the bus ID that the hibmc driver reports for the hibmc graphics card on the board. In particular, the bus id is missing the "pci:" prefix that most other cards provide: [1]
> - The busid reported on the arm64 system is "0007:a1:00.0"
> - The busid reported on a amd64 system is "pci:0000:00:02.0"
>
> X tests for this prefix. A missing prefix for PCI cards leads to an
> Xorg crash.
>
> Fix this by using the set_pci_busid function from the DRM core.
>
> [Testcase]
> Successfully tested on a D05 board. [2]
>
> [Regression Potential]
> Changes are limited to the hibmc driver, so any regression should also be limited to that driver.
>
> [Notes]
> I submitted the patch upstream. However, upstream is refactoring the drm core, and set_busid is going away. That does fix this issue but the regression potential of the refactor is enormous, so this seems like the wiser approach. [3]
>
> [0]: https:/
> [1]: https:/
> [2]: https:/
> [3]: https:/
>
> To manage notifications about this bug go to:
> https:/