Comment 1 for bug 421044

Revision history for this message
psl (slansky) wrote : Re: zsyncmake doesn't check blocksize parameter well

I tested small values of blocksize, like 1, 2, 4, 8, 16 and it doesn't make serious problem to zsync client. Technical problem is that when blocksize is 8, the zsync file size is similar to original file, when blocksize is 4, zsync file is double in size compared to original file, etc. It doesn't make sense to create files with blocksize smaller than 16 and this should be checked by zsyncmake utility. When blocksize parameter is 0, default value of blocksize (2048) is used.

I modified one zsync file to have blocksize 100 in the header; this is checked by the zsync client and it give up. I like it...

$ zsync http://server/zsync/missing.iso.100.zsync
#################### 100.0% 0.0 kBps DONE

nonsensical blocksize 100

The same should happen when value greater than 16384 is found in the zsync file header.