zfs dkms kernel module failed to build

[jondee]

I'm already using ZFS (since 15.10) so I'm re-submitting in case this provides more data to debug the issue. Otherwise looks like a duplicate of #1568721

ProblemType: Package
DistroRelease: Ubuntu 16.04
Package: zfs-dkms 0.6.5.6-0ubuntu8
ProcVersionSignature: Ubuntu 4.2.0-35.40-generic 4.2.8-ckt5
Uname: Linux 4.2.0-35-generic x86_64
NonfreeKernelModules: zfs zunicode zcommon znvpair zavl nvidia_uvm nvidia_modeset nvidia
ApportVersion: 2.20.1-0ubuntu2
Architecture: amd64
DKMSBuildLog:
 DKMS make.log for zfs-0.6.5.6 for kernel 4.4.0-21-generic (x86_64)
 Sat 23 Apr 18:29:18 BST 2016
 make: *** No targets specified and no makefile found. Stop.
DKMSKernelVersion: 4.4.0-21-generic
Date: Sat Apr 23 18:29:22 2016
InstallationDate: Installed on 2013-07-04 (1024 days ago)
InstallationMedia: Ubuntu 13.04 "Raring Ringtail" - Release amd64 (20130424)
PackageVersion: 0.6.5.6-0ubuntu8
RelatedPackageVersions:
 dpkg 1.18.4ubuntu1
 apt 1.2.10ubuntu1
SourcePackage: zfs-linux
Title: zfs-dkms 0.6.5.6-0ubuntu8: zfs kernel module failed to build
UpgradeStatus: Upgraded to xenial on 2016-04-23 (0 days ago)

[jondee (jonathandilks)]

Doesn't seem to cause any actual problems after install. ZFS has continued to just work the same as before the upgrade. Strange :S

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Christian Reis (kiko)]

Is the issue here that you can't DKMS-build a module which is already present and loaded in the kernel? I assume you're aware that in 16.04 zfs is provided precompiled?

[jondee (jonathandilks)]

@kiko Interesting thought there! That could be it! I am aware of the change, however from a users point of view, I believe enabling the zfsutils-linux package remains the same to actually use ZFS.

Perhaps the issue is the zfs-dkms package should be removed (entirely or as a dependency of zfsutils-linux) in 16.04? The zfs-dkms package, is however still installed on my system and it doesn't seem to be causing any issues presently.

[Christian Reis (kiko)]

The zfs-dkms package is what's causing the failure to build you reported in this bug. Remove the package and see if the problem reoccurs.

[jondee (jonathandilks)]

@kiko You're probably quite right that it's the zfs-dkms package that's the problem. However removing it now seem's rather fruitless now that the upgrade is completed (which is the only case where I've personally seen this bug occur), and the package is not causing any problems/ errors presently (so I'd have very little to report back even if I did remove it from my existing system :) )

More to the point, if everything you're saying is correct, shouldn't we be working to remove this package from the 16.04 repos and most importantly ensure it is removed during the upgrade process, so that users don't have to suffer a failed upgrade?

[Christian Reis (kiko)]

Hmm. Does this problem not reoccur every time a new kernel package is installed? Or does it happen only once when upgrading into Xenial?

I'm not sure we should remove the package from the repo, given I think there are valid use cases for it, but perhaps we could make it so installing the Xenial kernel removed it.

[Dustin Kirkland  (kirkland)]

Colin, can you have a look?

[jondee (jonathandilks)]

@kiki I don't believe so, I'll keep an a special eye out for it, but I imagine I would have seen it by now tbh. I think nearly all of the bug reports come from the upgrade process where the upgrade tool automatically starts a bug report on launchpad whenever it encounters an error.

"but perhaps we could make it so installing the Xenial kernel removed it." Sounds perfect :)

[Alan B. Clements (alan-clements)]

This is a duplicate of bug #1654708 (q.v)

Replaced both occurrences
   error = posix_acl_valid(acl);
with
   error = posix_acl_valid(ip, acl);
in file:
    /usr/src/zfs-0.6.5.6/module/zfs/zpl_xattr.c

 dkms remove -m zfs -v 0.6.5.6 -k 4.4.0-62-generic
 dkms install --force -m zfs -v 0.6.5.6 -k 4.4.0-62-generic
does compiles now.

[Colin Ian King (colin-king)]

This was fixed with:

zfs-linux (0.6.5.6-0ubuntu16) xenial; urgency=medium

  * Enable zfs to respect RSIZE_LIMIT limits (LP: #1656259)
    - backport of zfs upstream commit 4b908d32200b6e5c7b5115322b6c8d25e770daa0
      ("Linux 4.8 compat: posix_acl_valid()") to facilitate changes in posix_acl_valid.
      1015-Linux-4.8-compat-posix_acl_valid.patch
    - backport of upstream commit 933ec999511f3d29de005bfa8966ae007b161c0f
      ("Retire .write/.read file operations")
      1016-Retire-.write-.read-file-operations.patch

with upstream commit:

commit 4b908d32200b6e5c7b5115322b6c8d25e770daa0
Author: Brian Behlendorf <email address hidden>
Date: Tue Aug 2 11:11:45 2016 -0700

    Linux 4.8 compat: posix_acl_valid()

    The posix_acl_valid() function has been updated to require a
    user namespace. Filesystem callers should normally provide the
    user_ns from the super block associcated with the ACL; the
    zpl_posix_acl_valid() wrapper has been added for this purpose.
    See https://github.com/torvalds/linux/commit/0d4d717f for
    complete details.

    Signed-off-by: Brian Behlendorf <email address hidden>
    Signed-off-by: Nikolay Borisov <email address hidden>
    Signed-off-by: Chunwei Chen <email address hidden>
    Closes #4922

https://github.com/zfsonlinux/zfs/pull/4922

[Colin Ian King (colin-king)]

If this does not fix the bug and you believe it is the same issue, please re-open this bug.