Comment 0 for bug 1915177

Revision history for this message
Kleber Sacilotto de Souza (kleber-souza) wrote :

[Impact]
Groovy linux 5.8.0-44.50 backported from upstream stable the following commit, which broke the build of xtables-addons dkms modules on Groovy and Focal 5.8 kernels based on this release:

"netfilter: use actual socket sk rather than skb sk when routing harder" (Upstream commit 46d6c5ae953cc0be38efd0e469284df7c4328cf8).

On Focal, xtables-addons was already changed to accommodate this change to the 5.4 kernels (bug 1907109), however the signature detection mechanism used for the 5.4 kernels doesn't work with the 5.8 kernels so a more robust mechanism will be needed.

[Test case]
Install xtables-addons-dkms package.

[Fix]
The proposed fix is to add a script (configure_features.sh) which will be executed before the dkms modules are build to detect which function signature is provided by the kernel being built for. This script will save a header file with some #define's which will be used by the compatibility headers to choose the correct function signature. This is a mechanism similar to what is already used by some other dkms packages.

[Where problems could occur]
If the function signature detection is not done correctly, the dkms packages could fail building again.