Comment 20 for bug 293346

Revision history for this message
In , quanxian (quanxian-wang) wrote :

Ubuntu has accept the patch and follow up it by deleting the line
+ FatalError("i830_update_dri_buffers() failed\n");

After that, I checked the code, seems it will not bring effect. The reason is when you apply the map based on the current offset, there are two conditions.
1) you have mapped the offset
it will return fail, because you have mapped before, there is a map in the list based on your offset of buffer. We can ignore it because we have gotten what we want.
2) we don't mapped this offset
it will return success, this is just want we want for this bug. Because there is some offest changed, and no map happens, it will bring some effect to xserver. Therefore we run this will solve the problem.

As a summary, deleting this line will be OK from my understanding.

Quanxian Wang