Comment 54 for bug 1053959

Revision history for this message
In , dn (nobled) wrote :

(In reply to comment #47)
> The only thing I've found so far...
>
> commit a16616209bb2dcb7aaa859b38e154f0a10faa82b
> Author: Chris Wilson <email address hidden>
> Date: Sat Apr 14 19:03:25 2012 +0100
>
> uxa: Fix leak of glyph mask for unhandled glyph composition
>
> Could this seemingly insignificant path be the cause of your misery?

The bad news is, that commit didn't fix it. The good news is, an earlier one *did*:

commit fde8a010b3d9406c2f65ee99978360a6ca54e006
Author: Chris Wilson <email address hidden>
Date: Fri Mar 30 12:47:21 2012 +0100

    uxa: Remove broken render glyphs-to-dst

    Reported-by: Vincent Untz <email address hidden>
    Reported-by: Robert Bradford <email address hidden>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=48045
    Signed-off-by: Chris Wilson <email address hidden>

I made sure; reverting that commit on top of master causes the leak to re-appear. (Only question is, was the leak in that function all along, or did it happen to call a leaky path somewhere else?)

Just a note on my testing: gnome-system-monitor only begins to leak after it's been running for 60 seconds while viewing the 'Resources' tab-- ie, enough time has passed to fill up the whole X axis of the rolling 'CPU History' graph. Once history starts falling off the back edge, the numbers start climbing.