Comment 28 for bug 333377

Revision history for this message
In , Matthijs Kooijman (matthijskooijman) wrote :

Since the bisected commit is still a bit of a big one, I've narrowed it down a bit more. While trying to understand the code, I think I found a bug in the commit (but unfortunately, fixing it didn't solve the problem of this report). I've created a fix for this small bug, which I put up here:

  http://git.stderr.nl/gitweb?p=matthijs/upstream/xf86-video-ati.git;a=commit;h=9222a02cf7

Anyway, back to the real bug. I've further narrowed the problem down to the change "- disable the crtcs in legacy crtc dpms". This branch shows my findings:

  http://git.stderr.nl/gitweb?p=matthijs/upstream/xf86-video-ati.git;a=shortlog;h=refs/heads/200m-debug

Two commits are significant here:
Working: http://git.stderr.nl/gitweb?p=matthijs/upstream/xf86-video-ati.git;a=commit;h=e59c01d
Broken: http://git.stderr.nl/gitweb?p=matthijs/upstream/xf86-video-ati.git;a=commit;h=3c4b0090

The first has most of the faulty commit applied, the second has the final part of the faulty commit applied as well. I've also included a some debug output in the working commit that shows the Legacy DPMS mode switches and register contents before the mode switch.

I'm attaching two Xorg logfiles, one made with the working version (which shows startup and a switch to text mode and back to X) and one with the broken version (which shows startup and a switch to text mode, nothing is logged after that due to the freeze).