Comment 15 for bug 921082

Revision history for this message
In , Jsagarribay (jsagarribay) wrote :

Hello, after commit c8b098214b44cf0585d78c460401ea7d143769f3 (Don't store fake events in the motion history) the touchpad is unusable: the pointer moves too fast, and it keeps on moving (in the same direction) when the finger stops, as long as it is touching the touchpad.

It works as expected in HEAD with that commit reverted. This is the bisection log:

git bisect start
# good: [065a0b495d2a7eb76b61f9eec85248aefae4c8ee] synaptics 1.5.0
git bisect good 065a0b495d2a7eb76b61f9eec85248aefae4c8ee
# bad: [3804a0ee0bec455fcc61a469dd907738ff5589bd] Constify priv->device
git bisect bad 3804a0ee0bec455fcc61a469dd907738ff5589bd
# good: [98e8481cf4911506403b8963fc32c61a74cf679e] Bump to 1.4.99.1
git bisect good 98e8481cf4911506403b8963fc32c61a74cf679e
# bad: [4fe1b58c2c6903961a84077363a0c8de5736c650] Scroll: Modify ScrollData in repeat_scrollbuttons
git bisect bad 4fe1b58c2c6903961a84077363a0c8de5736c650
# good: [458c7251295e767fae7a0ac3366212361bce25a6] Use hardware time where possible
git bisect good 458c7251295e767fae7a0ac3366212361bce25a6
# bad: [f40bbf7494a6122d464e3fff4309f69af2a20e4a] Revise palm check logic
git bisect bad f40bbf7494a6122d464e3fff4309f69af2a20e4a
# bad: [ffed18dfffda32de7282e44c5b8d1fb7d5454b54] Update count_packet_finger in store_history, not get_delta
git bisect bad ffed18dfffda32de7282e44c5b8d1fb7d5454b54
# bad: [c8b098214b44cf0585d78c460401ea7d143769f3] Don't store fake events in the motion history
git bisect bad c8b098214b44cf0585d78c460401ea7d143769f3

I also found some strangeness with edge scrolling, sometimes it generated spurious events in the opposite direction (i.e. scroll down but get several button 4 events, instead of one button 5). I'm unable to reproduce it now with the commit reverted, but I'm not sure it's the same bug.