thanks for the patch! here's a few comments:
- style: no spaces after negations. for example, if (! inside_active_area) should be if (!inside_active_area)
- don't use 0 as the "no range" marker. there might be touchpads (one day) that have negative ranges. In the server we use valid ranges instead, i.e. (min >= max) designates an unset range.
- one could argue that if the range is user-configured anyway we don't need to query for it (eventcomm.c).
- second-to-last hunk is whitespace only hunk, please remove
I'm a bit confused abut the comment above the is_inside_active_area(.. HIST(0)) part. can you paraphrase this please?
thanks for the patch! here's a few comments: active_ area)
- style: no spaces after negations. for example, if (! inside_active_area) should be if (!inside_
- don't use 0 as the "no range" marker. there might be touchpads (one day) that have negative ranges. In the server we use valid ranges instead, i.e. (min >= max) designates an unset range.
- one could argue that if the range is user-configured anyway we don't need to query for it (eventcomm.c).
- second-to-last hunk is whitespace only hunk, please remove
I'm a bit confused abut the comment above the is_inside_ active_ area(.. HIST(0)) part. can you paraphrase this please?