Comment 18 for bug 270002

Revision history for this message
Bryce Harrington (bryce) wrote :

I've reviewed the PPA fix, which contains a fix both for this bug and for 282735. The fix for this bug is:

+ touch = finger && !priv->finger_state;
+ release = !finger && priv->finger_state;
+- move = (((abs(hw->x - priv->touch_on.x) >= para->tap_move) ||
++ move = ((priv->tap_max_fingers <= ((priv->horiz_scroll_twofinger_on || priv->vert_scroll_twofinger_on)? 2 : 1)) &&
++ ((abs(hw->x - priv->touch_on.x) >= para->tap_move) ||
+ (abs(hw->y - priv->touch_on.y) >= para->tap_move)));
+

From a risk standpoint, this looks quite safe, with all risk localized to touchpad behavior, so I'm comfortable with it. Also, given the confirmation in comment #15, it sounds ready for upload.