Your patch is a good start towards getting this fixed, but it's not working correctly yet. I noticed you said it was a rounding issue, can it be fixed? In case you think that decreasing these values by just a few points isn't bad, remember that the values get decreased upon *each* invocation of totem (and possibly other players), again and again. After about 5-6 invocations, totem causes XVideo output to become washed out.
To illustrate:
1. Fresh start -> first totem invocation
Name: XV_COLORKEY
- Current value: 66046
+ Current value: 66051
Name: XV_BRIGHTNESS
Flags: XvGettable XvSettable
- Current value: 0
+ Current value: -1
Name: XV_CONTRAST
- Current value: 128
+ Current value: 126
Name: XV_SATURATION
- Current value: 512
+ Current value: 509
2. Fresh start -> second totem invocation
Name: XV_COLORKEY
- Current value: 66046
+ Current value: 66051
Name: XV_BRIGHTNESS
- Current value: 0
+ Current value: -2
Name: XV_CONTRAST
- Current value: 128
+ Current value: 124
Name: XV_SATURATION
- Current value: 512
+ Current value: 506
Etc.
Again, my video card: 00:02.0 VGA compatible controller: Intel Corporation 82852/855GM Integrated Graphics Device (rev 02)
Thomas,
Your patch is a good start towards getting this fixed, but it's not working correctly yet. I noticed you said it was a rounding issue, can it be fixed? In case you think that decreasing these values by just a few points isn't bad, remember that the values get decreased upon *each* invocation of totem (and possibly other players), again and again. After about 5-6 invocations, totem causes XVideo output to become washed out.
To illustrate:
1. Fresh start -> first totem invocation
Name: XV_COLORKEY
- Current value: 66046
+ Current value: 66051
Name: XV_BRIGHTNESS
Flags: XvGettable XvSettable
- Current value: 0
+ Current value: -1
Name: XV_CONTRAST
- Current value: 128
+ Current value: 126
Name: XV_SATURATION
- Current value: 512
+ Current value: 509
2. Fresh start -> second totem invocation
Name: XV_COLORKEY
- Current value: 66046
+ Current value: 66051
Name: XV_BRIGHTNESS
- Current value: 0
+ Current value: -2
Name: XV_CONTRAST
- Current value: 128
+ Current value: 124
Name: XV_SATURATION
- Current value: 512
+ Current value: 506
Etc.
Again, my video card: 00:02.0 VGA compatible controller: Intel Corporation 82852/855GM Integrated Graphics Device (rev 02)