Please see the man page for xscreensaver-getimage for an explication of the chooseRandomImages option. Setting it to false does not mean images should be selected sequentially. So the "bug report" here is invalid.
However, a feature to have a sequential slide show sounds like a good idea. I would encourage you to make an "upstreamable" patch. I don't see why Ubuntu should carry such a delta in form of a undocumented "hack". There is also a couple of issues in your patch (which seems to have been released in Natty without any review) which I have tried to address in the attached patch:
1) there is no checking for index overflow once the image list has run out
2) the hard-coded index counter file name is not portable
3) the counter is incremented, then decremented in a conditional clause (confusing)
I have omitted the check for chooseRandomImages in the configuration file, and just rely on the existence of an index file. It might make sense to check for a "chooseSequentialImages" option instead, which also needs to be honoured in other code. But the upstream developer might have other suggestions for how to implement this.
BTW, is this part of a bigger plan for something in Ubuntu, or just a private "itch"?
Please see the man page for xscreensaver- getimage for an explication of the chooseRandomImages option. Setting it to false does not mean images should be selected sequentially. So the "bug report" here is invalid.
However, a feature to have a sequential slide show sounds like a good idea. I would encourage you to make an "upstreamable" patch. I don't see why Ubuntu should carry such a delta in form of a undocumented "hack". There is also a couple of issues in your patch (which seems to have been released in Natty without any review) which I have tried to address in the attached patch:
1) there is no checking for index overflow once the image list has run out
2) the hard-coded index counter file name is not portable
3) the counter is incremented, then decremented in a conditional clause (confusing)
I have omitted the check for chooseRandomImages in the configuration file, and just rely on the existence of an index file. It might make sense to check for a "chooseSequenti alImages" option instead, which also needs to be honoured in other code. But the upstream developer might have other suggestions for how to implement this.
BTW, is this part of a bigger plan for something in Ubuntu, or just a private "itch"?