Comment 16 for bug 220510

Revision history for this message
Martin Pitt (pitti) wrote :

Bryce, I rejected your xserver-xorg upload to hardy-proposed. The actual patch (debian/patches/167_xf86AutoConfig_geode_addition.diff) seems alright, but the changelog is totally wrong:

+xorg-server (2:1.4.1~git20080131-1ubuntu9.2) hardy-proposed; urgency=low
+
+ * 169_xf86AutoConfig_choose_default_driver_if_no_pci.patch
+ - Choose the default driver for the platform instead of the generic
+ default (vesa) if there is no PCI info. Without this, on platforms
+ like PS3 where fbdev should be used rather than vesa, the system
+ will fail to start up. (LP: #219424)
+
+ -- Bryce Harrington <email address hidden> Wed, 14 May 2008 16:24:15 -0700
+
+xorg-server (2:1.4.1~git20080131-1ubuntu9.1) hardy-proposed; urgency=low
+
+ * 42_dont_break_grab_and_focus_for_window_when_redirecting.diff:
+ - Disables grabs/lose-focus state change events when composite has
+ unmapped windows. Prevents side effect where gnome-screensaver loses
+ its grab when compiz unredirects the fullscreen lock window. Prevents
+ password authentication bypass.
+ (LP: #160264, ref LP 122549, debian 449108)
+
+ -- Bryce Harrington <email address hidden> Tue, 13 May 2008 18:59:47 -0700

There is no xorg-server in hardy-proposed, thus the upload should be ubuntu9.1, not ubuntu9.2, and there should be just one changelog. Also, neither of the changelogs describes the actual patch, and the patches in the changelog are not present in the diff.