Comment 21 for bug 1015183

Revision history for this message
Martin von Gagern (gagern) wrote :

Hi Chase,

thank you for looking into this, and working towards a solution.

Is the patch you referenced intended as a replacement for both my patches? Working with the touch screen alone, things work out fairly well. But if I also use a mouse, then the lack of a TOUCH_END event still causes the mouse moves to register as drags, i.e. with state 0x100. So I feel like your patch might be a suitable replacement for the one in comment #12, but the one in comment #11 is still required.

I guess you head a good reason to write the changes I mentioned in comment #8, the ones which #11 backs out. I must confess I still haven't fully understood the rationale behind that commit, mostly because I still don't know about that listener concept. So perhaps you want to improve that change instead of reverting it. A proper proof should probably get rid of every occurrence of the TOUCH_END macro in the code. It should be tested on a setup with both a touch and a classical mouse device.