Comment 31 for bug 199486

Revision history for this message
In , Julien Cristau (jcristau) wrote :

> --- Comment #9 from Jeremy Huddleston <email address hidden> 2011-10-03 00:31:49 PDT ---
> configure.ac needs a bit more work. For example, if I pass --with-consolekit
> and I don't actually have it, configure should error out, but it just silently
> continues without consolekit. Other than that, it looks good. Mind updating
> the patch? Feel free to email it to xorg-devel for review, or attach here and
> I'll review it again. Bonus points if you use 'git format-patch' with a commit
> message that I can use rather than just 'git diff'
>
Hrm. What about the comments from Loic?