wrong drag & drop behaviour between desktop and folders

[Mirek Ryšán]

(Sry - new guy - I hope, that I selected right package and write all important info.)

Thunar 1.2.3 (Xfce 4.8)
Xubuntu 12.04.1 LTS, fully updated

When I drag file from the desktop to any folder, I can use Control/Shift key and select between coping or pasting as expected.

But when I drag any file from any folder TO the desktop, small icon with "+" appears in right corner (that looks right) but file is moved, not copied. Using Control/Shift key changes small move/copy icon in the corner, but no change in real behaviour - file is moved everytime. And I am not able to copy it just with using drag & drop. Using Control & C and Control & V works as expected.

Hope it helps...

[Pete (somerandomname)]

When dragging a file between the Desktop and a Thunar window the file is copied. When dragging a file between two Thunar windows or within the same Thunar window, the file is moved. Holding down shift allows a move to/from the desktop but does nothing for Thunar. I'd like to suggest that the Desktop follow the same convention Thunar does, or at least default to the same behavior.

In all cases the mouse cursor correctly indicates the operation that will be performed(arrow for move, plus for copy).

[i (iiiiii-deactivatedaccount)]

In my tests with xfdesktop 4.10.0-4.fc17 and thunar 1.4.0-1.fc17, dragging from thunar to desktop moves the file (when same owner just like thunar to thunar) but dragging from desktop to thunar copies it.
shift-dragging from desktop to thunar correctly moves the file but ctrl-dragging from thunar to desktop fails to copy the file (it's still moved).

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Eric Koegel (eric-koegel)]

*** Bug 8644 has been marked as a duplicate of this bug. ***

[Michael.S.G (ozfalcon)]

Some clarification on what's happening.

Bug #1
When unmodified dragging a file from the file manager to the desktop, The drag modifier shows the file is being copied (Small '+' symbol) but the file is moved.
ie. The drag modifier incorrectly shows copy instead of nothing (move).

Bug #2
When copy dragging (ctrl held down) a file from the file manager to the desktop, The drag modifier shows the file is being copied (Small '+' symbol) but the file is moved.
ie. The copy operation is not carried out, The file is moved instead.

Inconsistancy #1
Unmodified dragging from the desktop to a file manager copies the file.
Unmodified dragging from a file manager to the desktop moves the file.
ie. What default used (Copy or Move) is irrelevent, The issue here is both the operations should be consistant in their action of either Copy or Move.

Long standing issue
These problems are a barnacle for the unaware user, The issue may seem innocuous but has a real possiblility of people loosing files because they assume (As indicated) a copy operation has been carried out when infact a move operation has occured.

[Michael.S.G (ozfalcon)]

Created attachment 5950
Before the file dragged from file manager to desktop.

[Michael.S.G (ozfalcon)]

Created attachment 5951
After the file dragged from file manager to desktop.

[Michael.S.G (ozfalcon)]

Comment on attachment 5950
Before the file dragged from file manager to desktop.

Notice the drag modifier indicates the file is being copied (Small '+' symbol).

[Thaddaeus Tintenfisch (thad-fisch-deactivatedaccount)]

Works fine here. Tested with xfdesktop 4.11.8 git.

The remaining oddity is the default drag&drop action when dragging a file from the desktop to a file manager.

-> thunar = copy
-> pcmanfm = move
-> nautilus = copy

[Thaddaeus Tintenfisch (thad-fisch-deactivatedaccount)]

Created attachment 5981
patch (thunar)

Thunar tries to access cached file information which does not exist when the user drags a file from desktop to thunar. As result, the copy action is determined to be the ideal drag and drop action.
The attached patch adds normal file info lookup as fallback for this case.

[Michael.S.G (ozfalcon)]

After patching 1.6.5, I now recieve an error:
"The file transfer could not be performed" etc.
---> See attached image.

Reverting to an unpatched 1.6.5 works but still has the issues previously mentioned.

Note I am using xfdesktop4 v4.10.2-3 (Debian 8 testing [aka Jessie])
I'll try xdesktop4 v4.11.8 and see what sort of results are produced.

[Michael.S.G (ozfalcon)]

Created attachment 5984
Thunar 1.6.5 Patched Error

[Michael.S.G (ozfalcon)]

Comment on attachment 5984
Thunar 1.6.5 Patched Error

Disregard this image. Was due to a bad package installation.

[Michael.S.G (ozfalcon)]

Correction:
The patch on Thunar 1.6.5 worked and the file moves when dragged from the desktop to the file manager as expected.

Dragging from the file manager to the desktop is unaffected by Thunar 1.6.5 + patch and exhibits the previously listed issues.
I'll comment on this once I have xfdesktop4 v4.11.8 installed.

[Michael.S.G (ozfalcon)]

I have installed xfdesktop 4.11.8 and the problem is resolved.
ie. Drag from file manager now works correctly with copy, move & link.

The last inconsistancy is resolved with the Thunar patch by Thaddaeus Tintenfisch (attachment 5981).
ie. Drag from desktop to file manager is corrected to a move operation.

These are two separate bugs from two separate packages, xfdesktop 4.10 and below and Thunar without Thaddaeus's patch.

As the xfdesktop issue is resolved in 4.11.8, The only thing remaining is for
Thaddaeus Tintenfisch patch (attachment 5981) to be submitted & included in Thunar.

Just to help anyone (With debian systems) the packages installed were:
Remove:
libxfce4ui-1-dev

Install:
xfce-keyboard-shortcuts_4.11.1-2_all.deb
libxfce4ui-1-0_4.11.1-2_i386.deb
libxfce4ui-common_4.11.1-2_all.deb
libxfce4ui-utils_4.11.1-2_i386.deb
xfdesktop4-data_4.11.8-1_all.deb
xfdesktop4_4.11.8-1_i386.deb

Note:
libxfce4ui-utils was probably not required, But I included it anyway.

Debian package links, Search for required packages:
https://packages.debian.org/search?keywords=xfdesktop4

[Hjudt-l (hjudt-l)]

Thanks for the patch. Pushed to master: http://git.xfce.org/xfce/thunar/commit/?id=cdfdb7290abb270f5f98c93089c3b6e3c35859bc

[Michael.S.G (ozfalcon)]

Information:
Thunar 1.6.6 was released prior to the patch being pushed to master.

So it looks like Thunar 1.6.7 will include this patch.

Great work and thanks.

[Majestyx (majestyx)]

 kernel: Thunar[1101]: segfault at 2 ip 00007f2da30bd7ed sp 00007ffc23cc2c48 error 4 in libgobject-2.0.so.0.4800.0[7f2da3089000+52000]
Apr 28 11:39:58 mmx whoopsie[622]: [11:39:58] Not online; processing later (/var/crash/_usr_bin_thunar.1000.crash).