Improve error dialog when upgrade from 1.4 fails

[WW]

The first time I ran Evolution Mail, I was confronted with an error window
telling me that an upgrade failed. I'll attach a screen shot with the message.
 I clicked on Continue, and was asked if I wanted to delete my old data. I
clicked on Delete, since I shouldn't have had any old data. I don't think these
messages should have occurred, especially the first one.

[WW (wweckesser)]

Created an attachment (id=244)
Screenshot of initialize Evolution error

[Vincent Untz (vuntz)]

Did you have an ~/evolution/ folder? (this should be the case if you ran
evolution 1.4 at least once before)

[WW (wweckesser)]

It appears that I had an old evolution directory in my home directory. When I
installed ubuntu, I also created a new /home partition. I wanted a fresh start
with all the applications that I used, so I only copied the non-hidden files
from my old home to the new one (thinking that most programs store configuration
data in hidden files). I took a look at the backup of my old home directory, and
it contains an evolution directory--I must have tried it at least once while
running my previous distro. So the evolution directory was copied to my new
home directory. Sorry for the false alarm. (But that error message could have
been a little more helpful. :-)

[Vincent Untz (vuntz)]

Well if config.xmldb did not exist or was corrupted, then we don't know why and
I don't think we'll ever know. There are already some bugs in b.x.o about this.

I think it's right to show the error dialog, so the real question is: how can we
improve the message in the dialog? I feel the message is ok, but suggestions are
welcome :-)

[WW (wweckesser)]

I still have a copy of my old evolution directory; it does not contain a file
called config.xmldb. Here is what it has:

   local/
   addressbook-sources.xml
   searches.xml
   shortcuts.xml
   vfolders.xml
   camel-cert.db
   cert8.db
   secmod.db
   key3.db

I don't know enough about Evolution to have any useful suggestions about the
upgrade process. But since you asked, here is one suggestion about the
particular message that I got. It said that the file did not exist or was
corrupted. Presumably, the program tried to open the file, so when that failed,
it should have said that the file did not exist. If it had been able to open
the file, but then discovered that something was wrong with the contents, _then_
it should have reported an error about the file being corrupted.

[Vincent Untz (vuntz)]

(I'm reopening since we don't need more informations)

I'm not sure this will improve things: the user doesn't care if the file exists
or is corrupted. What's important for him is that he sees an error dialog.

Would it be a good idea to not show the error dialog? I don't think so: the user
needs to know that his old settings might be unavailable after the upgrade.

I think a good solution would be to hide the "Unable to read..." sentence. We
would add a "More details" expander that shows that sentence when expanded.

[Sebastien Bacher (seb128)]

import bugs should be fixed with the new version. The dialog is a detail and
evolution's hacker have already load of bugs to fix. I'm closing this bug. Feel
free to reopen if you disagree